From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752922AbcBKC4B (ORCPT ); Wed, 10 Feb 2016 21:56:01 -0500 Received: from mail-ob0-f194.google.com ([209.85.214.194]:35017 "EHLO mail-ob0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbcBKCz6 (ORCPT ); Wed, 10 Feb 2016 21:55:58 -0500 Subject: Re: [PATCH v5] mmc: OCTEON: Add host driver for OCTEON MMC controller To: David Daney , Aaro Koskinen References: <1455125775-7245-1-git-send-email-matt.redfearn@imgtec.com> <56BB7B2F.60307@caviumnetworks.com> <20160210234907.GC1640@darkstar.musicnaut.iki.fi> <56BBD6AD.2090902@caviumnetworks.com> Cc: Matt Redfearn , linux-mmc@vger.kernel.org, david.daney@cavium.com, ulf.hansson@linaro.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Aleksey Makarov , Chandrakala Chavva , Aleksey Makarov , Leonid Rosenboim , Peter Swain , Aaron Williams From: Florian Fainelli Message-ID: <56BBF83B.8020908@gmail.com> Date: Wed, 10 Feb 2016 18:55:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BBD6AD.2090902@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 10/02/2016 16:32, David Daney a écrit : > On 02/10/2016 03:49 PM, Aaro Koskinen wrote: >> Hi, >> >> On Wed, Feb 10, 2016 at 10:02:23AM -0800, David Daney wrote: >>> On 02/10/2016 09:36 AM, Matt Redfearn wrote: >>>> + pr_warn(FW_WARN "%s: Legacy property '%s'. Please remove\n", >>>> + node->full_name, legacy_name); >>> >>> I don't like this warning message. >>> >>> The vast majority of people that see it will not be able to change their >>> firmware. So it will be forever cluttering up their boot logs. >> >> Until they switch to use APPENDED_DTB. :-) >> > > I am philosophically opposed to making the DTB an internal kernel > implementation detail. > > For OCTEON boards, it is an ABI between the boot firmware and the > kernel, and is impractical to change. > > One could argue that many years ago, when the decision was made (by me), > that we should have opted to carry in the kernel source code tree the > DTS files for all OCTEON boards ever made, but we did not do that. Due > to the non-reversibility of time, the decision is hard to reverse. > > In the case of this MMC driver, the only real difference is that two > properties have legacy names that later had differing "official" names. > The overhead of carrying the legacy bindings is very low. Since there is an existing FDT patching infrastructure in arch/mips/cavium-octeon/ would not that be a place where you could put an adaptation layer between your legacy firmware properties and the upstream binding? -- Florian