From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbcBKL1q (ORCPT ); Thu, 11 Feb 2016 06:27:46 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35468 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbcBKL1o (ORCPT ); Thu, 11 Feb 2016 06:27:44 -0500 Subject: Re: [PATCH V5 10/11] soc: mediatek: PMIC wrap: add mt6323 slave support To: John Crispin References: <1454841778-35529-1-git-send-email-blogic@openwrt.org> <1454841778-35529-11-git-send-email-blogic@openwrt.org> Cc: Sascha Hauer , Henry Chen , Thierry Reding , Flora Fu , Steven Liu , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org From: Matthias Brugger Message-ID: <56BC702D.8030806@gmail.com> Date: Thu, 11 Feb 2016 12:27:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454841778-35529-11-git-send-email-blogic@openwrt.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/16 11:42, John Crispin wrote: > Add support for MT6323 slaves. This PMIC can be found on MT2701 and MT7623 > EVB. The only function that we need to touch is pwrap_init_cipher(). > > Signed-off-by: John Crispin > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 47 ++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 2628271..5fbdd5c 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -91,6 +91,31 @@ enum dew_regs { > PWRAP_DEW_CIPHER_RDY, > PWRAP_DEW_CIPHER_MODE, > PWRAP_DEW_CIPHER_SWRST, > + > + /* MT6323 only regs */ > + PWRAP_DEW_CRC_SWRST, > + PWRAP_DEW_CIPHER_EN, > + PWRAP_DEW_RDDMY_NO, > + PWRAP_DEW_RDATA_DLY_SEL, > +}; We just use PWRAP_DEW_CIPHER_EN, right? I think it makes the code more readable if we just declare the registers we actually need. Thanks, Matthias