From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbcBKLl4 (ORCPT ); Thu, 11 Feb 2016 06:41:56 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34993 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbcBKLly (ORCPT ); Thu, 11 Feb 2016 06:41:54 -0500 Subject: Re: [PATCH V5 11/11] soc: mediatek: PMIC wrap: add MT2701/7623 support To: John Crispin References: <1454841778-35529-1-git-send-email-blogic@openwrt.org> <1454841778-35529-12-git-send-email-blogic@openwrt.org> Cc: Sascha Hauer , Henry Chen , Thierry Reding , Flora Fu , Steven Liu , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org From: Matthias Brugger Message-ID: <56BC737F.9070503@gmail.com> Date: Thu, 11 Feb 2016 12:41:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454841778-35529-12-git-send-email-blogic@openwrt.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/16 11:42, John Crispin wrote: > Add the registers, callbacks and data structures required to make the > wrapper work on MT2701 and MT7623. > > Signed-off-by: John Crispin > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 162 ++++++++++++++++++++++++++++++++++ > 1 file changed, 162 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 5fbdd5c..ee6d917 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -52,6 +52,7 @@ > #define PWRAP_DEW_WRITE_TEST_VAL 0xa55a > > /* macro for manual command */ > +#define PWRAP_MAN_CMD_SPI_WRITE_NEW (1 << 14) > #define PWRAP_MAN_CMD_SPI_WRITE (1 << 13) > #define PWRAP_MAN_CMD_OP_CSH (0x0 << 8) > #define PWRAP_MAN_CMD_OP_CSL (0x1 << 8) > @@ -202,6 +203,17 @@ enum pwrap_regs { > PWRAP_DCM_EN, > PWRAP_DCM_DBC_PRD, > > + /* MT2701 only regs */ > + PWRAP_OP_TYPE, > + PWRAP_MSB_FIRST, > + PWRAP_GPS_STA, > + PWRAP_ADC_CMD_ADDR, > + PWRAP_PWRAP_ADC_CMD, > + PWRAP_ADC_RDY_ADDR, > + PWRAP_ADC_RDATA_ADDR1, > + PWRAP_ADC_RDATA_ADDR2, > + PWRAP_ADC_WRAP_SEL, > + Same here, we should just declare the registers actually used. Thanks, Matthias