From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751177AbcBKL7J (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Feb 2016 06:59:09 -0500
Received: from mail-wm0-f54.google.com ([74.125.82.54]:34851 "EHLO
	mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750725AbcBKL7H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Feb 2016 06:59:07 -0500
Subject: Re: [PATCH V5 06/11] soc: mediatek: PMIC wrap: SPI_WRITE needs a
 different bitmask for MT2701/7623
To: John Crispin <blogic@openwrt.org>
References: <1454841778-35529-1-git-send-email-blogic@openwrt.org>
 <1454841778-35529-7-git-send-email-blogic@openwrt.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
        Henry Chen <henryc.chen@mediatek.com>,
        Thierry Reding <treding@nvidia.com>, Flora Fu <flora.fu@mediatek.com>,
        Steven Liu <steven.liu@mediatek.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
From: Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <56BC7787.8070308@gmail.com>
Date: Thu, 11 Feb 2016 12:59:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1454841778-35529-7-git-send-email-blogic@openwrt.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 07/02/16 11:42, John Crispin wrote:
> MT2701 and MT7623 use a different bitmask for the SPI_WRITE command.
>

Something like:
Different SoCs will use different bitmask for the SPI_WRITE command. 
This patch defines the bitmask in the pmic_wrapper_type to allow an easy 
addition.

Well you are the native speaker, so maybe it's not the best to just use 
my version ;)

Regards,
Matthias