From: Jens Axboe <axboe@kernel.dk>
To: "Matias Bjørling" <m@bjorling.me>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@fb.com
Subject: Re: [PATCH] null_blk: oops when initializing without lightnvm
Date: Thu, 11 Feb 2016 08:56:28 -0700 [thread overview]
Message-ID: <56BCAF2C.6030809@kernel.dk> (raw)
In-Reply-To: <1455198553-24359-1-git-send-email-m@bjorling.me>
On 02/11/2016 06:49 AM, Matias Bjørling wrote:
> If the LightNVM subsystem is not compiled into the kernel, and the
> null_blk device driver requests lightnvm to be initialized. The call to
> nvm_register fails and the null_add_dev function cleans up the
> initialization. However, at this point the null block device has
> already been added to the nullb_list and thus a second cleanup will
> occur when the function has returned, that leads to a double call to
> blk_cleanup_queue.
Deferring the add seems fine, applied for 4.5.
--
Jens Axboe
prev parent reply other threads:[~2016-02-11 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 13:49 [PATCH] null_blk: oops when initializing without lightnvm Matias Bjørling
2016-02-11 15:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCAF2C.6030809@kernel.dk \
--to=axboe@kernel.dk \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).