From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbcBKRmT (ORCPT ); Thu, 11 Feb 2016 12:42:19 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33972 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbcBKRmQ (ORCPT ); Thu, 11 Feb 2016 12:42:16 -0500 Subject: Re: [PATCH v3 1/2] usb: musb: Fix DMA for host mode To: Joshua Henderson , linux-kernel@vger.kernel.org References: <1455206297-6002-1-git-send-email-joshua.henderson@microchip.com> Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56BCC7F5.3030500@cogentembedded.com> Date: Thu, 11 Feb 2016 20:42:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455206297-6002-1-git-send-email-joshua.henderson@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 06:58 PM, Joshua Henderson wrote: > From: Cristian Birsan > > Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in > musb_host.c part5") introduces a problem setting DMA host mode. > > This commit fixes the done condition that advances the musb schedule. > Without this patch the the msub_advance_schedule() is called immediately > after receiving an endpoint RX interrupt without waiting for the DMA > transfer to complete. As a consequence when the dma complete interrupt > arrives the in_qh member of hw_ep is already null an the musb_host_rx() > exits on !urb error case. You're supposed to document your own changes above --- when you're pushing someone other's patch... in this minimalistic patch, the changes were so dramatic that you could have changed the authorship instead... > Signed-off-by: Cristian Birsan > Signed-off-by: Joshua Henderson > --- > Changes since v2: > - Put function call in if condition. > Changes since v1: > - Don't add unecessary new variable. Just correct done. > --- > drivers/usb/musb/musb_host.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c > index 795a45b..6a81066 100644 > --- a/drivers/usb/musb/musb_host.c > +++ b/drivers/usb/musb/musb_host.c > @@ -2003,10 +2003,9 @@ void musb_host_rx(struct musb *musb, u8 epnum) > qh->offset, > urb->transfer_buffer_length); > > - done = musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh, > - urb, xfer_len, > - iso_err); > - if (done) > + if (musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh, > + urb, xfer_len, > + iso_err)) Can be compressed to 2 lines. [...] Other than that, I'm content now. :-) MBR, Sergei