* [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine
@ 2016-02-11 15:58 Joshua Henderson
2016-02-11 17:44 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Henderson @ 2016-02-11 15:58 UTC (permalink / raw)
To: linux-kernel
Cc: Cristian Birsan, Joshua Henderson, Felipe Balbi,
Greg Kroah-Hartman, linux-usb
From: Cristian Birsan <cristian.birsan@microchip.com>
Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c")
introduces a problem setting the desired channel mode for the Mentor DMA
engine.
There is a case where an address is incorrectly assigned to the DMA
channel desired mode when it should instead be assigned the actual mode
value. This results in the value of channel->desired_mode not being
correct.
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
---
Changes since v2:
- Fix wording in commit message.
Changes since v1:
- Fix commit comment citing the cause of the regression.
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 6a81066..0803061 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE);
csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */
}
- channel->desired_mode = mode;
+ channel->desired_mode = *mode;
musb_writew(epio, MUSB_TXCSR, csr);
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine
2016-02-11 15:58 [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson
@ 2016-02-11 17:44 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2016-02-11 17:44 UTC (permalink / raw)
To: Joshua Henderson, linux-kernel
Cc: Cristian Birsan, Felipe Balbi, Greg Kroah-Hartman, linux-usb
On 02/11/2016 06:58 PM, Joshua Henderson wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c")
> introduces a problem setting the desired channel mode for the Mentor DMA
> engine.
>
> There is a case where an address is incorrectly assigned to the DMA
> channel desired mode when it should instead be assigned the actual mode
> value. This results in the value of channel->desired_mode not being
> correct.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-11 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 15:58 [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson
2016-02-11 17:44 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).