From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbcBKSKy (ORCPT ); Thu, 11 Feb 2016 13:10:54 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:36104 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcBKSKv (ORCPT ); Thu, 11 Feb 2016 13:10:51 -0500 Message-ID: <56BCCEA9.4050509@gmail.com> Date: Thu, 11 Feb 2016 10:10:49 -0800 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Marc Zyngier , robh+dt@kernel.org CC: Robin Murphy , grant.likely@linaro.org, devicetree@vger.kernel.org, mark.rutland@arm.com, david.daney@cavium.com, stuart.yoder@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56BC6ABA.5020605@arm.com> In-Reply-To: <56BC6ABA.5020605@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/2016 3:04 AM, Marc Zyngier wrote: > On 09/02/16 11:04, Robin Murphy wrote: >> The existing msi-map code is fine for shifting the entire RID space >> upwards, but attempting finer-grained remapping reveals a bug. It turns >> out that we are mistakenly treating the msi-base part as an offset, not >> as a new base to remap onto, so things get squiffy when rid-base is >> nonzero. Fix this, and at the same time add a sanity check against >> having msi-map-mask clash with a nonzero rid-base, as that's another >> thing one can easily get wrong. >> >> CC: >> Signed-off-by: Robin Murphy > > Rob, Frank, > > Are you willing to take this one through the OF tree? Or should we route > it through the IRQ tree? It'd be good if it make it into 4.5. > > Thanks, > > M. > Just to be picky, I would like the patch to be split in two for easier bisecting, but if Rob is happy with a single patch I'm ok with that. Rob, will you pick this up? Acked-by: Frank Rowand -Frank