From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750977AbcBKXOU (ORCPT ); Thu, 11 Feb 2016 18:14:20 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37721 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbcBKXOS (ORCPT ); Thu, 11 Feb 2016 18:14:18 -0500 Subject: Re: [PATCH v2 5/6] serial: 8250/mediatek: fix building with SERIAL_8250=m To: Arnd Bergmann , Greg Kroah-Hartman References: <1455205297-1021302-1-git-send-email-arnd@arndb.de> <1455205297-1021302-6-git-send-email-arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, Paul Gortmaker , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , Sascha Hauer , Eddie Huang , Masahiro Yamada , linux-mediatek@lists.infradead.org From: Matthias Brugger Message-ID: <56BD15C6.6040006@gmail.com> Date: Fri, 12 Feb 2016 00:14:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455205297-1021302-6-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/16 16:41, Arnd Bergmann wrote: > The Mediatek 8250 driver has a 'bool' Kconfig symbol, but that > breaks when SERIAL_8250 is a loadable module: > > drivers/tty/built-in.o: In function `mtk8250_set_termios': > :(.text+0x1bee8): undefined reference to `serial8250_do_set_termios' > :(.text+0x1bf10): undefined reference to `uart_get_baud_rate' > :(.text+0x1c09c): undefined reference to `uart_get_divisor' > drivers/tty/built-in.o: In function `mtk8250_do_pm': > :(.text+0x1c0d0): undefined reference to `serial8250_do_pm' > drivers/tty/built-in.o: In function `mtk8250_probe': > :(.text+0x1c2e4): undefined reference to `serial8250_register_8250_port' > serial/8250/8250_mtk.c:287:242: error: data definition has no type or storage class [-Werror] > serial/8250/8250_mtk.c:287:122: error: 'mtk8250_platform_driver_init' defined but not used [-Werror=unused-function] > > This changes the symbol to a 'tristate', so the dependency on > SERIAL_8250 also works when that is set to 'm'. > To actually build the driver, we also need to include . > > Signed-off-by: Arnd Bergmann > --- Acked-by: Matthias Brugger