From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbcBLJeJ (ORCPT ); Fri, 12 Feb 2016 04:34:09 -0500 Received: from foss.arm.com ([217.140.101.70]:59940 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbcBLJeH (ORCPT ); Fri, 12 Feb 2016 04:34:07 -0500 Subject: Re: [PATCH 4/4] mailbox: mailbox-test: add support for separate tx/rx buffer with single channel To: Lee Jones References: <1455210808-29395-1-git-send-email-sudeep.holla@arm.com> <1455210808-29395-5-git-send-email-sudeep.holla@arm.com> <20160212091505.GS20693@x1> Cc: Sudeep Holla , Jassi Brar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <56BDA70B.70008@arm.com> Date: Fri, 12 Feb 2016 09:34:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160212091505.GS20693@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/16 09:15, Lee Jones wrote: > On Thu, 11 Feb 2016, Sudeep Holla wrote: > [...] >> @@ -294,9 +295,13 @@ static int mbox_test_probe(struct platform_device *pdev) >> >> /* It's okay for MMIO to be NULL */ >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - tdev->mmio = devm_ioremap_resource(&pdev->dev, res); >> - if (IS_ERR(tdev->mmio)) >> - tdev->mmio = NULL; >> + tdev->tx_mmio = devm_ioremap_resource(&pdev->dev, res); >> + if (IS_ERR(tdev->tx_mmio)) >> + tdev->tx_mmio = NULL; > > Nit: I'd prefer to see a new line separator here. > OK will add it >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> + tdev->rx_mmio = devm_ioremap_resource(&pdev->dev, res); >> + if (IS_ERR(tdev->rx_mmio)) >> + tdev->rx_mmio = tdev->tx_mmio; >> >> tdev->tx_channel = mbox_test_request_channel(pdev, "tx"); >> tdev->rx_channel = mbox_test_request_channel(pdev, "rx"); >> @@ -304,6 +309,9 @@ static int mbox_test_probe(struct platform_device *pdev) >> if (!tdev->tx_channel && !tdev->rx_channel) >> return -EPROBE_DEFER; >> >> + if (!tdev->rx_channel && (tdev->rx_mmio != tdev->tx_mmio)) >> + tdev->rx_channel = tdev->tx_channel; >> + >> tdev->dev = &pdev->dev; >> platform_set_drvdata(pdev, tdev); > > Otherwise code looks good. Nice extension. > Thanks for the review. > Acked-by: Lee Jones > -- Regards, Sudeep