From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbcBLMeF (ORCPT ); Fri, 12 Feb 2016 07:34:05 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35589 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbcBLMeC (ORCPT ); Fri, 12 Feb 2016 07:34:02 -0500 Subject: Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO To: Sudip Mukherjee , Florian Fainelli References: <1455272306-30251-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" From: Helmut Buchsbaum Message-ID: <56BDD136.50208@gmail.com> Date: Fri, 12 Feb 2016 13:33:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455272306-30251-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2016 11:18 AM, Sudip Mukherjee wrote: > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > with the error: > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > GPIO is now used to reset the switch so we should have a dependency on > GPIOLIB. > > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") > Cc: Helmut Buchsbaum > Signed-off-by: Sudip Mukherjee > --- > drivers/net/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index f0a7702..c6a4fe1 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -261,4 +261,4 @@ endif # PHYLIB > > config MICREL_KS8995MA > tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" > - depends on SPI > + depends on SPI && GPIOLIB > You're definitely right! This somehow slipped through, sorry for that!