From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbcBLQvU (ORCPT ); Fri, 12 Feb 2016 11:51:20 -0500 Received: from e18.ny.us.ibm.com ([129.33.205.208]:45528 "EHLO e18.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcBLQvS (ORCPT ); Fri, 12 Feb 2016 11:51:18 -0500 X-IBM-Helo: d01dlp01.pok.ibm.com X-IBM-MailFrom: tyreld@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-scsi@vger.kernel.org Subject: Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines To: James Bottomley , Tyrel Datwyler References: <1455154348-3226-1-git-send-email-tyreld@linux.vnet.ibm.com> <1455154348-3226-4-git-send-email-tyreld@linux.vnet.ibm.com> <1455295395.2396.22.camel@HansenPartnership.com> Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com, jthumshirn@suse.de, manoj@linux.vnet.ibm.com From: Tyrel Datwyler Message-ID: <56BE0D7D.3050703@linux.vnet.ibm.com> Date: Fri, 12 Feb 2016 08:51:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455295395.2396.22.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021216-0045-0000-0000-0000035187A9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2016 08:43 AM, James Bottomley wrote: > On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote: >> Add defines for mad version and mad os_type, and replace the magic >> numbers in set_adapter_info() accordingly. >> >> Signed-off-by: Tyrel Datwyler >> --- > > Is there some reason you didn't carry the review tag over from this: > > http://mid.gmane.org/20160204084459.GW27969@c203.arch.suse.de > > ? > > James The patch is slightly changed from v1. A define for AIX os type was added as mentioned in the cover letter v2 changes, and I moved the defines to the mad_adapter_info_data structure around the fields they apply. -Tyrel > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >