From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbcBLRnN (ORCPT ); Fri, 12 Feb 2016 12:43:13 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33004 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbcBLRnM (ORCPT ); Fri, 12 Feb 2016 12:43:12 -0500 Subject: Re: [PATCH] arm64: make irq_stack_ptr more robust To: Will Deacon References: <1455227590-9837-1-git-send-email-yang.shi@linaro.org> <56BDE260.20504@arm.com> <56BE18AB.4090902@linaro.org> <20160212174116.GI17901@arm.com> Cc: James Morse , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org From: "Shi, Yang" Message-ID: <56BE19AF.7000605@linaro.org> Date: Fri, 12 Feb 2016 09:43:11 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160212174116.GI17901@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/2016 9:41 AM, Will Deacon wrote: > On Fri, Feb 12, 2016 at 09:38:51AM -0800, Shi, Yang wrote: >> On 2/12/2016 5:47 AM, James Morse wrote: >>> On 11/02/16 21:53, Yang Shi wrote: >>>> Switching between stacks is only valid if we are tracing ourselves while on the >>>> irq_stack, so it is only valid when in current and non-preemptible context, >>>> otherwise is is just zeroed off. >>> >>> Given it was picked up with CONFIG_DEBUG_PREEMPT: >>> >>> Fixes: 132cd887b5c5 ("arm64: Modify stack trace and dump for use with irq_stack") >> >> Wii add in v2. > > I already queued the patch with this and the whitespace fix, so no need > for a v2. Thanks so much. Yang > > Will >