From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbcBLS5F (ORCPT ); Fri, 12 Feb 2016 13:57:05 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38816 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbcBLS5D (ORCPT ); Fri, 12 Feb 2016 13:57:03 -0500 Subject: Re: [PART1 RFC 6/9] svm: Add interrupt injection via AVIC To: Borislav Petkov References: <1455285574-27892-1-git-send-email-suravee.suthikulpanit@amd.com> <1455285574-27892-7-git-send-email-suravee.suthikulpanit@amd.com> <20160212141650.GB4504@pd.tnic> <56BE0043.9050701@amd.com> <20160212171406.GF4099@pd.tnic> <56BE229D.6030206@redhat.com> <20160212183048.GG4099@pd.tnic> Cc: Suravee Suthikulpanit , joro@8bytes.org, alex.williamson@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com From: Paolo Bonzini Message-ID: <56BE2AFB.4000504@redhat.com> Date: Fri, 12 Feb 2016 19:56:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160212183048.GG4099@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/2016 19:30, Borislav Petkov wrote: > On Fri, Feb 12, 2016 at 07:21:17PM +0100, Paolo Bonzini wrote: >> Hmm, currently things such as MSR_VM_HSAVE_PA are defined in msr-index.h. > > But that one is used in 3 files AFAICT. Ok, next examples: MSR_VM_CR and MSR_VM_IGNNE. :) >> It's okay for me to move them to kvm_host.h or similar, but they should >> all be treated the same. Right now this means adding the doorbell MSR >> to msr-index.h. > > Only if it is used in multiple files. The doorbell thing is used once in > svm.c. > > We don't want to make msr-index.h an encyclopedia of any MSR ever > defined :-) Are you okay with moving all the SVM MSRs to virtext.h instead? Thanks, Paolo