From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751497AbcBNGeO (ORCPT ); Sun, 14 Feb 2016 01:34:14 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34155 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbcBNGeM (ORCPT ); Sun, 14 Feb 2016 01:34:12 -0500 Subject: Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding To: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Javier Martinez Canillas References: <1455038632-14545-1-git-send-email-javier@osg.samsung.com> Cc: k.kozlowski.k@gmail.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Alexandre Belloni , Rob Herring , Alessandro Zummo From: Krzysztof Kozlowski Message-ID: <56C01FDD.9050204@samsung.com> Date: Sun, 14 Feb 2016 15:34:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455038632-14545-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze: > The S3C Real Time Clock driver requires the clock and source clock to > be defined in the device node but that requirement is not documented. +Cc: Alessandro Zummo No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks but rest of compatible devices need only rtc clock. Best regards, Krzysztof > > Signed-off-by: Javier Martinez Canillas > > --- > > Documentation/devicetree/bindings/rtc/s3c-rtc.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > index ac2fcd6ff4b8..1068ffce9f91 100644 > --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.txt > @@ -14,6 +14,10 @@ Required properties: > interrupt number is the rtc alarm interrupt and second interrupt number > is the rtc tick interrupt. The number of cells representing a interrupt > depends on the parent interrupt controller. > +- clocks: Must contain a list of phandle and clock specifier for the rtc > + and source clocks. > +- clock-names: Must contain "rtc" and "rtc_src" entries sorted in the > + same order as the clocks property. > > Example: > > @@ -21,4 +25,6 @@ Example: > compatible = "samsung,s3c6410-rtc"; > reg = <0x10070000 0x100>; > interrupts = <44 0 45 0>; > + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; > + clock-names = "rtc", "rtc_src"; > }; >