From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbcBNGxa (ORCPT ); Sun, 14 Feb 2016 01:53:30 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35596 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbcBNGx1 (ORCPT ); Sun, 14 Feb 2016 01:53:27 -0500 Subject: Re: [PATCH] regulator: Rename files for max77686 and max77802 drivers To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1455250463-5955-1-git-send-email-javier@osg.samsung.com> Cc: k.kozlowski.k@gmail.com, Andi Shyti , Liam Girdwood , linux-samsung-soc@vger.kernel.org, Mark Brown From: Krzysztof Kozlowski Message-ID: <56C0245F.1080209@samsung.com> Date: Sun, 14 Feb 2016 15:53:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455250463-5955-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 12.02.2016 o 13:14, Javier Martinez Canillas pisze: > The max77686 and max77802 regulator drivers are for sub-devices of a MFD > driver for some PMIC blocks. But the same object file name (max77686.o) > was used for both the common MFD driver and the max77686 regulator one. > > This confuses kbuild if both drivers are built as module causing the MFD > driver to not be copied when installing the modules. > > Also, max77{686,802} are a quite generic name for MFD subdevices drivers > so it is better to rename them to max77{686,802}-regulator like it's the > case for most regulator drivers. > > Signed-off-by: Javier Martinez Canillas > > --- > > MAINTAINERS | 2 +- > drivers/regulator/Makefile | 4 ++-- > drivers/regulator/{max77686.c => max77686-regulator.c} | 0 > drivers/regulator/{max77802.c => max77802-regulator.c} | 0 > 4 files changed, 3 insertions(+), 3 deletions(-) > rename drivers/regulator/{max77686.c => max77686-regulator.c} (100%) > rename drivers/regulator/{max77802.c => max77802-regulator.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 97b99f24ea53..863eb59e101b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6904,7 +6904,7 @@ MAXIM MAX77802 MULTIFUNCTION PMIC DEVICE DRIVERS > M: Javier Martinez Canillas > L: linux-kernel@vger.kernel.org > S: Supported > -F: drivers/*/*max77802.c > +F: drivers/*/*max77802*.c > F: Documentation/devicetree/bindings/*/*max77802.txt > F: include/dt-bindings/*/*max77802.h Looks fine, but can you also update the max77686 entry with extended wildcard? Best regards, Krzysztof