From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbcBNVCG (ORCPT ); Sun, 14 Feb 2016 16:02:06 -0500 Received: from arrakis.dune.hu ([78.24.191.176]:42412 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbcBNVCE (ORCPT ); Sun, 14 Feb 2016 16:02:04 -0500 Subject: Re: [PATCH V5 04/11] soc: mediatek: PMIC wrap: split SoC specific init into callback To: Matthias Brugger References: <1454841778-35529-1-git-send-email-blogic@openwrt.org> <1454841778-35529-5-git-send-email-blogic@openwrt.org> <56BC7674.9030706@gmail.com> Cc: Sascha Hauer , Henry Chen , Thierry Reding , Flora Fu , Steven Liu , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org From: John Crispin Message-ID: <56C0EB32.4080701@openwrt.org> Date: Sun, 14 Feb 2016 22:01:38 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BC7674.9030706@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2016 12:54, Matthias Brugger wrote: >> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c >> b/drivers/soc/mediatek/mtk-pmic-wrap.c >> index b22b664..e3bbee5 100644 >> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c >> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c >> @@ -372,6 +372,7 @@ struct pmic_wrapper_type { >> enum pwrap_type type; >> u32 arb_en_all; >> int (*init_reg_clock)(struct pmic_wrapper *wrp); >> + int (*init_special)(struct pmic_wrapper *wrp); > > Nit: > I wonder if we can find a better name for the callback, as init_special > sounds quite generic to me. > > Thanks, > Matthias Hi, At first I considered enable_wrapper as the mt8135/8173 code seems to do just that. however mt2701 does an init of the ADC. So how about using init_soc_specific ? John