From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754796AbcBNXqt (ORCPT ); Sun, 14 Feb 2016 18:46:49 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51738 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753712AbcBNXqr (ORCPT ); Sun, 14 Feb 2016 18:46:47 -0500 X-AuditID: cbfec7f4-f79026d00000418a-3a-56c111e423f7 Subject: Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com, broonie@kernel.org, gregkh@linuxfoundation.org, a.zummo@towertech.it References: <1455038794-9921-1-git-send-email-ldewangan@nvidia.com> <1455038794-9921-5-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56C111DF.2020005@samsung.com> Date: Mon, 15 Feb 2016 08:46:39 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1455038794-9921-5-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Zd0nggfDDG7/4LZYcvEqu0XHtcVM FlMfPmGzuP7lOatF8+L1bBZv3q5hsnj9wtBi6b7VLBb3vx5ltLi8aw6bxf7ODkYHbo8nmy4y euyZeJLNY9OqTjaPO9f2sHnsn7uG3aO3+R2bx5b+u+wefVtWMXpMn/eTyePzJrkArigum5TU nMyy1CJ9uwSujOt/brAVLGCv2DFhO2MDYydbFyMHh4SAicSDiUxdjJxAppjEhXvr2UBsIYGl jBKdq9wh7KeMEl19KiC2sECUxPxrt1i7GLk4RAROMErceLqJEaKoVuLY2jWsIDazQKjEhZfX mUFsNgFjic3Ll4Dt4hXQknh2NxQkzCKgKnHj13J2EFtUIELicGcXmM0rICjxY/I9FpByTgEX ic2L8kFMZgE9ifsXtSCGy0tsXvOWeQKjwCwkDbMQqmYhqVrAyLyKUTS1NLmgOCk911CvODG3 uDQvXS85P3cTIyRmvuxgXHzM6hCjAAejEg9vxJkDYUKsiWXFlbmHGCU4mJVEeE9+AQrxpiRW VqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBsWuxzvKVuxsYZ19i DZ5Z4GHkVOH5d+etmd92Nh1LYnHOb3vhtlg6MHTt7B0P9h/TlCwWPfdlmowbx73P26vX7agK uh8wV6JCipH3w+ps23tqhTItRxX5fl9cNPcqGyOLV1FhZQtPzenrEUXif6WLp81ydmhRVWz8 85FDeOLKpWo5Un5PQ6SeK7EUZyQaajEXFScCAOcRDp+VAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.02.2016 02:26, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas > FWIW, on max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof