From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754810AbcBNXtJ (ORCPT ); Sun, 14 Feb 2016 18:49:09 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51762 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831AbcBNXtG (ORCPT ); Sun, 14 Feb 2016 18:49:06 -0500 X-AuditID: cbfec7f4-f79026d00000418a-cf-56c11270684e Subject: Re: [PATCH V7 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com, broonie@kernel.org, gregkh@linuxfoundation.org, a.zummo@towertech.it References: <1455038794-9921-1-git-send-email-ldewangan@nvidia.com> <1455038794-9921-6-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56C1126B.80900@samsung.com> Date: Mon, 15 Feb 2016 08:48:59 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1455038794-9921-6-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Zd0CoYNhBjPnS1osuXiV3aLj2mIm i6kPn7BZXP/ynNWiefF6Nos3b9cwWbx+YWixdN9qFov7X48yWlzeNYfNYn9nB6MDt8eTTRcZ PfZMPMnmsWlVJ5vHnWt72Dz2z13D7tHb/I7NY0v/XXaPvi2rGD2mz/vJ5PF5k1wAVxSXTUpq TmZZapG+XQJXxuWvL9gKPgpWrP49nb2BcTtfFyMnh4SAicTGuQeZIGwxiQv31rN1MXJxCAks ZZTYP3UKlPOUUWL6oqmMIFXCAgkSa65NYgZJiAicYJS48XQTWEJIoFZi7eubbCA2s0CoxIWX 15lBbDYBY4nNy5eAxXkFNCQOPHoCVs8ioCoxc/56sLioQITE4c4udogaQYkfk++xgNicAi4S nfPXA83hAJqpJ3H/ohbEeHmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqmliYXFCel5xrqFSfm Fpfmpesl5+duYoREz5cdjIuPWR1iFOBgVOLhjThzIEyINbGsuDL3EKMEB7OSCO/JL0Ah3pTE yqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MPos2dJ6T3oZ24SK 2XEhWtxWZodNhVfbHLyt3fRPPdN79nWrvsWvz7Cyyn143li6f1ph0GafgwWTWh8E7Nm/57SK m1DJufqHd+5KhH/fKfuQI2Kre9/RF9Jf5lyO6Ft+MqjO4ek7rpeXS7Y/MPm+zceu9XCFmo+5 ScqndDmv5Ohp1xK4ik3nlSqxFGckGmoxFxUnAgA9GlsEmgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.02.2016 02:26, Laxman Dewangan wrote: > To make RTC block of MAX77686/MAX77802 as independent driver, > move the registration of i2c device, regmap for register access > and irq_chip for interrupt support inside the RTC driver. > Removed the same initialisation from MFD driver. > > Having this change will allow to reuse this driver for different > PMIC/devices from Maxim Semiconductor if they kept same RTC IP on > different PMIC. Some of examples as PMIC MAX77620, MAX20024 where > same RTC IP used and hence driver for these chips will use this > driver only for RTC support. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas > > --- > Changes from V1: > - Remove changes from Kconfig. > - Maintain all register definition in max77686 private header and remove > the movement to rtc driver. > - Taken care of all comments on V1 from Krzysztof and Javier. > > Changes from V2: > - Taken care of missed sequence for removing the resource. > - Fix the crash when doing unbind by using requested_threaded_irq() > instead of demv_requested_threaded_irq(). > > Changes from V3: > - Fix the issue of suspend-resume with unbind/bind by unmapping the > virq. > > Changes from V4: > - Dispose mapped irq in error path in probe > > Changes from V5: > - Remove the new APIs from regmap as functionality added to dispose the > virq inside the regmap_del_irq_chip(). > > Changes from V6: > Make this as 5th of series as regmap change applied independently. > Also rebase on linux-next 20160209 > > drivers/mfd/max77686.c | 85 +------------------- > drivers/rtc/rtc-max77686.c | 148 ++++++++++++++++++++++++++++++----- > include/linux/mfd/max77686-private.h | 3 - > 3 files changed, 130 insertions(+), 106 deletions(-) > Reviewed-by: Krzysztof Kozlowski On max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof