From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752230AbcBOHPR (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 02:15:17 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:17364 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751551AbcBOHPO convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 02:15:14 -0500
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Sun, 14 Feb 2016 23:14:20 -0800
Message-ID: <56C17AFD.8050203@nvidia.com>
Date: Mon, 15 Feb 2016 15:15:09 +0800
From: Wei Ni <wni@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Rob Herring <robh@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>
CC: Thierry Reding <thierry.reding@gmail.com>, Zhang Rui <rui.zhang@intel.com>,
        <MLongnecker@nvidia.com>, Stephen Warren <swarren@wwwdotorg.org>,
        Mikko Perttunen <mikko.perttunen@kapsi.fi>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm
References: <1454057260-16412-1-git-send-email-wni@nvidia.com> <CAL_JsqKwQOxkWyYPcv6sBe8ELUuPx4N+iUF94J8R63bRxsGK4g@mail.gmail.com>
In-Reply-To: <CAL_JsqKwQOxkWyYPcv6sBe8ELUuPx4N+iUF94J8R63bRxsGK4g@mail.gmail.com>
X-Originating-IP: [10.19.224.146]
X-ClientProxiedBy: HKMAIL104.nvidia.com (10.18.16.13) To HKMAIL101.nvidia.com
 (10.18.16.10)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Rob

On 2016年02月12日 22:42, Rob Herring wrote:
> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni <wni@nvidia.com> wrote:
>> Add hw-trips sub-node for soctherm, which is
>> used to describe the hardware trip points for
>> each soctherm sensors.
> 
> I still don't understand why you are doing something custom here.
> What's wrong with what is defined in:
> 
> Documentation/devicetree/bindings/thermal/thermal.txt

In current thermal framework, it support to set trip points for the thermal
zones, but this trip point is handled by SW, doesn't have callbacks to program
the hardware.
There had patches:
[PATCH 12/16] thermal: thermal: Add support for hardware-tracked trip points,
http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000866.html,
which can support to program hardware to set trip points, but it seems this
series didn't be taken.
So I add this hw-trip-points sub-node for soctherm.

Hi, Sascha Hauer

Thanks.
Wei.

> 
> Rob
>