From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbcBOIw7 (ORCPT ); Mon, 15 Feb 2016 03:52:59 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34891 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbcBOIw5 (ORCPT ); Mon, 15 Feb 2016 03:52:57 -0500 Subject: Re: [PATCH 2/2] net: dsa: remove phy_disconnect from error path To: Vivien Didelot , Sascha Hauer , netdev@vger.kernel.org References: <1455187489-30771-1-git-send-email-s.hauer@pengutronix.de> <1455187489-30771-2-git-send-email-s.hauer@pengutronix.de> <8737szi7e0.fsf@ketchup.mtl.sfl> Cc: linux-kernel@vger.kernel.org, Andrew Lunn , Guenter Roeck From: Neil Armstrong Organization: Baylibre Message-ID: <56C191E2.90704@baylibre.com> Date: Mon, 15 Feb 2016 09:52:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <8737szi7e0.fsf@ketchup.mtl.sfl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 04:39 PM, Vivien Didelot wrote: > Hi Sascha, > > Sascha Hauer writes: > >> The phy has not been initialized, disconnecting it in the error >> path results in a NULL pointer exception. Drop the phy_disconnect >> from the error path. >> >> Signed-off-by: Sascha Hauer >> --- >> net/dsa/slave.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/dsa/slave.c b/net/dsa/slave.c >> index 40b9ca7..91e3b2f 100644 >> --- a/net/dsa/slave.c >> +++ b/net/dsa/slave.c >> @@ -1194,7 +1194,6 @@ int dsa_slave_create(struct dsa_switch *ds, struct device *parent, >> if (ret) { >> netdev_err(master, "error %d registering interface %s\n", >> ret, slave_dev->name); >> - phy_disconnect(p->phy); >> ds->ports[port] = NULL; >> free_netdev(slave_dev); >> return ret; > > I'm adding Neil in the loop, since he did some work similar to this, if > I'm not mistaken. > > Thanks, > -v > He's right, the phy is not yet created in this error path. Acked-by: Neil Armstrong Thanks Vivien, Neil