From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752913AbcBOLQy (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 06:16:54 -0500
Received: from mail-lb0-f177.google.com ([209.85.217.177]:32930 "EHLO
	mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752779AbcBOLQv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 06:16:51 -0500
Subject: Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute
To: Heinrich Schuchardt <xypron.glpk@gmx.de>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>
References: <1455513977-934-1-git-send-email-xypron.glpk@gmx.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
        Andrew Bresticker <abrestic@chromium.org>,
        Aaro Koskinen <aaro.koskinen@iki.fi>, devicetree@vger.kernel.org,
        linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56C1B3A0.4090301@cogentembedded.com>
Date: Mon, 15 Feb 2016 14:16:48 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1455513977-934-1-git-send-email-xypron.glpk@gmx.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 2/15/2016 8:26 AM, Heinrich Schuchardt wrote:

> Downstream packages like Debian flash-kernel rely on
> /proc/device-tree/model
> to determine how to install an updated kernel image.
>
> Most dts files provide this property.
> It is suggested by IEEE Std 1275-1994.
>
> This patch adds a model attribute for Octeon CPUs.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> index 9c48e05..a746678 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-3860";
> +	model = "Cavium Octeon 3XXX";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu>;
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> index 79b46fc..c8a292a 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-6880";
> +	model = "Cavium Octeon 68XX";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu2>;

     The ePAPR 1.1 standard says:

2.3.2 model

Property: model
Value type: <string>
Description:
	The model property value is a <string> that specifies the
  	manufacturer’s model number of the device.

	The recommended format is: “manufacturer,model”, where manufacturer
	is a string describing the name of the manufacturer (such as a stock
	ticker symbol), and model specifies the model number.

Example:
	model = “fsl,MPC8349EMITX”;

MBR, Sergei