From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbcBON6r (ORCPT ); Mon, 15 Feb 2016 08:58:47 -0500 Received: from lists.s-osg.org ([54.187.51.154]:48384 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbcBON6p (ORCPT ); Mon, 15 Feb 2016 08:58:45 -0500 Subject: Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a src clk To: Alexandre Belloni References: <1455542202-13977-1-git-send-email-javier@osg.samsung.com> <20160215134535.GB15219@piout.net> Cc: linux-kernel@vger.kernel.org, Rob Herring , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , rtc-linux@googlegroups.com, devicetree@vger.kernel.org From: Javier Martinez Canillas Message-ID: <56C1D98A.8040408@osg.samsung.com> Date: Mon, 15 Feb 2016 10:58:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160215134535.GB15219@piout.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alexandre, On 02/15/2016 10:45 AM, Alexandre Belloni wrote: > On 15/02/2016 at 10:16:42 -0300, Javier Martinez Canillas wrote : >> Commit 43f3408261a2 ("rtc: s3c: Document required clocks in the DT > > I'm pretty sure you shouldn't refer to a commit that is in linux-next. > The commit comes from Rob's dt/linus branch that uses Linux 4.5-rc3 as a base. I'm not a git expert but I thought that if the branch is not rebased and used for the pull request then the resulting commit in mainline would end with the same sha-1. But I can remove the mention to the commit and "Fixes:" tag since the commit is not yet in mainline, that should be more safe indeed. >> binding") added to the S3C binding doc the required clocks needed >> by the Real Time Clock but the S3C driver supports different HW IP >> and only the s3c6410 needs a source clock. >> >> Fix the DT binding explaning that the second clock is only needed > explaining ^ Ok, I'll fix that typo. >> by this IP block and not for the others. >> >> Reported-by: Krzysztof Kozlowski >> Fixes: 43f3408261a2 ("rtc: s3c: Document required clocks in the DT binding") >> Signed-off-by: Javier Martinez Canillas >> > > Anyway, I'm fine with it, feel free to add my ack. > Thanks, I'll add it in v2. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America