From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753404AbcBOO1c (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 09:27:32 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:53014 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751471AbcBOO1b (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 09:27:31 -0500
X-IronPort-AV: E=Sophos;i="5.22,450,1449532800"; 
   d="scan'208";a="338234617"
Subject: Re: [Xen-devel] [PATCH 4/4] xen/pcifront: Fix mysterious crashes when
 NUMA locality information was extracted.
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Tommi Airikka <tommi@airikka.net>, <linux-kernel@vger.kernel.org>,
        <xen-devel@lists.xenproject.org>, <david.vrabel@citrix.com>,
        <boris.ostrovsky@oracle.com>
References: <1455225026-25792-1-git-send-email-konrad.wilk@oracle.com>
 <1455225026-25792-5-git-send-email-konrad.wilk@oracle.com>
CC: <stable@vger.kernel.org>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <56C1E042.6000200@citrix.com>
Date: Mon, 15 Feb 2016 14:27:14 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1455225026-25792-5-git-send-email-konrad.wilk@oracle.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote:
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c

> @@ -576,6 +578,7 @@ static void pcifront_free_roots(struct pcifront_device *pdev)
>  		free_root_bus_devs(bus_entry->bus);
>  
>  		kfree(bus_entry->bus->sysdata);
> +		bus_entry->bus->sysdata = NULL;

I dropped this change, as it was unrelated.

I note that we free sysdata before removing the bus which looks racy to me.

David