From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbcBOOhO (ORCPT ); Mon, 15 Feb 2016 09:37:14 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48032 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbcBOOhK (ORCPT ); Mon, 15 Feb 2016 09:37:10 -0500 Subject: Re: [PATCH 4/4] xen/pcifront: Fix mysterious crashes when NUMA locality information was extracted. To: Konrad Rzeszutek Wilk References: <1455225026-25792-1-git-send-email-konrad.wilk@oracle.com> <1455225026-25792-5-git-send-email-konrad.wilk@oracle.com> <56BFD702.9010708@oracle.com> <20160215140532.GB3698@char.us.oracle.com> Cc: Tommi Airikka , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, david.vrabel@citrix.com, stable@vger.kernel.org From: Boris Ostrovsky Message-ID: <56C1E296.8060602@oracle.com> Date: Mon, 15 Feb 2016 09:37:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160215140532.GB3698@char.us.oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/15/2016 09:05 AM, Konrad Rzeszutek Wilk wrote: > On Sat, Feb 13, 2016 at 08:23:14PM -0500, Boris Ostrovsky wrote: >> On 02/11/2016 04:10 PM, Konrad Rzeszutek Wilk wrote: >>> This patch fixes the issue by: >>> 1) Use kzalloc to initialize to a well known state. >>> 2) Put 'struct pci_sysdata' at the start of 'pcifront_sd'. That >>> way access to the 'node' will access the right offset. >>> >>> CC: stable@vger.kernel.org >>> Signed-off-by: Konrad Rzeszutek Wilk >> Reviewed-by: Boris Ostrovsky >> >> (This, btw, is the second time we got bitten by pcifront_sd bit not being >> pci_sysdata. dc4fdaf0e48 was a workaround for a similar problem and we >> should have fixed it then). > I think that the dc4fdaf0e4839109169d8261814813816951c75f commit can be > reverted then? > > Ah no, b/c: > " Fixes: 97badf873ab6 (device property: Make it possible to use secondary firmware nodes)" Right --- the problem which that commit fixed was not specific to Xen but could be observed on ia64 as well. -boris