From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbcBOOi1 (ORCPT ); Mon, 15 Feb 2016 09:38:27 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:53343 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593AbcBOOiY (ORCPT ); Mon, 15 Feb 2016 09:38:24 -0500 X-IronPort-AV: E=Sophos;i="5.22,450,1449532800"; d="scan'208";a="338236315" Subject: Re: [Xen-devel] [PATCH] Fixes to Xen pcifront and pciback (v1) To: Konrad Rzeszutek Wilk , Tommi Airikka , , , References: <1455225026-25792-1-git-send-email-konrad.wilk@oracle.com> <56C1E24C.5040704@citrix.com> From: David Vrabel Message-ID: <56C1E2DE.7030507@citrix.com> Date: Mon, 15 Feb 2016 14:38:22 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <56C1E24C.5040704@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/16 14:35, David Vrabel wrote: > On 11/02/16 21:10, Konrad Rzeszutek Wilk wrote: >> Hey, >> >> These are patches that were developed for the Debian bug >> 810379 which san Tommi had openned. >> >> The issue around from the two XSA fixes - which introduced >> this regression. > > Applied to for-linus-4.6, thanks. I mean for-linus-4.5. I also fixed the minor style quibbles. David > I rewrote some of the commit messages for clarity. Please only put > relevant information in them and for regression fixes, make sure it's > clear what functionality regressed. > > e.g. #1 now reads: > > Commit 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (xen/pciback: Don't > allow MSI-X ops if PCI_COMMAND_MEMORY is not set) prevented enabling > MSI-X on passed-through virtual functions, because it checked the VF > for PCI_COMMAND_MEMORY but this is not a valid bit for VFs. > > Instead, check the physical function for PCI_COMMAND_MEMORY. > > David >