From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbcBOSWT (ORCPT ); Mon, 15 Feb 2016 13:22:19 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:33098 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbcBOSWR (ORCPT ); Mon, 15 Feb 2016 13:22:17 -0500 Subject: Re: [PATCH] phy: marvell: Fix and unify reg-init behavior To: Clemens Gruber , netdev@vger.kernel.org References: <1455558779-15953-1-git-send-email-clemens.gruber@pqgruber.com> <56C21695.1030809@gmail.com> Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Andrew Lunn From: Florian Fainelli Message-ID: <56C21756.1020702@gmail.com> Date: Mon, 15 Feb 2016 10:22:14 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56C21695.1030809@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/2016 10:19, Florian Fainelli wrote: > On 15/02/2016 09:52, Clemens Gruber wrote: >> For the Marvell 88E1510, marvell_of_reg_init was called too late (in >> m88e1510_config_aneg), which lead to the phy state machine being stuck >> at waiting for interrupts, which are off by default on the 88E1510. >> This further lead to the ethernet link not coming up at boot. >> For some Marvell PHYs, marvell_of_reg_init was not called at all. > > You could mention that this became apparent with ... 113c74d83eef ("net: phy: turn carrier off on phy attach") -- Florian