* [PATCH] regulator: vexpress: rename vexpress regulator implementation
@ 2016-01-29 17:37 Sudeep Holla
2016-02-10 18:49 ` Sudeep Holla
0 siblings, 1 reply; 6+ messages in thread
From: Sudeep Holla @ 2016-01-29 17:37 UTC (permalink / raw)
To: linux-kernel, Mark Brown
Cc: Sudeep Holla, Rusty Russell, Liviu Dudau, Lorenzo Pieralisi,
Liam Girdwood
The vexpress regulator implementation is currently just called vexpress.
This is a problem because it clashes with another module with the same
name in hardware monitors.
This patch renames the vexpress regulator implementation to
vexpress-regulator so that there will be no clash in the module namespace.
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Reported-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/regulator/Makefile | 2 +-
drivers/regulator/{vexpress.c => vexpress-regulator.c} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename drivers/regulator/{vexpress.c => vexpress-regulator.c} (100%)
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 980b1943fa81..755077a89a25 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -98,7 +98,7 @@ obj-$(CONFIG_REGULATOR_TPS65910) += tps65910-regulator.o
obj-$(CONFIG_REGULATOR_TPS65912) += tps65912-regulator.o
obj-$(CONFIG_REGULATOR_TPS80031) += tps80031-regulator.o
obj-$(CONFIG_REGULATOR_TWL4030) += twl-regulator.o
-obj-$(CONFIG_REGULATOR_VEXPRESS) += vexpress.o
+obj-$(CONFIG_REGULATOR_VEXPRESS) += vexpress-regulator.o
obj-$(CONFIG_REGULATOR_WM831X) += wm831x-dcdc.o
obj-$(CONFIG_REGULATOR_WM831X) += wm831x-isink.o
obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o
diff --git a/drivers/regulator/vexpress.c b/drivers/regulator/vexpress-regulator.c
similarity index 100%
rename from drivers/regulator/vexpress.c
rename to drivers/regulator/vexpress-regulator.c
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] regulator: vexpress: rename vexpress regulator implementation
2016-01-29 17:37 [PATCH] regulator: vexpress: rename vexpress regulator implementation Sudeep Holla
@ 2016-02-10 18:49 ` Sudeep Holla
2016-02-15 18:10 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Sudeep Holla @ 2016-02-10 18:49 UTC (permalink / raw)
To: linux-kernel, Mark Brown
Cc: Sudeep Holla, Rusty Russell, Liviu Dudau, Lorenzo Pieralisi,
Liam Girdwood
Hi Mark,
On 29/01/16 17:37, Sudeep Holla wrote:
> The vexpress regulator implementation is currently just called vexpress.
> This is a problem because it clashes with another module with the same
> name in hardware monitors.
>
> This patch renames the vexpress regulator implementation to
> vexpress-regulator so that there will be no clash in the module namespace.
>
Can you take this patch for v4.6 ? It was reported @[1]
--
Regards,
Sudeep
[1] https://lkml.org/lkml/2016/1/29/7
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: vexpress: rename vexpress regulator implementation
2016-02-10 18:49 ` Sudeep Holla
@ 2016-02-15 18:10 ` Mark Brown
2016-02-15 18:12 ` Mark Brown
2016-02-15 18:31 ` Sudeep Holla
0 siblings, 2 replies; 6+ messages in thread
From: Mark Brown @ 2016-02-15 18:10 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-kernel, Rusty Russell, Liviu Dudau, Lorenzo Pieralisi,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On Wed, Feb 10, 2016 at 06:49:54PM +0000, Sudeep Holla wrote:
> On 29/01/16 17:37, Sudeep Holla wrote:
> >The vexpress regulator implementation is currently just called vexpress.
> >This is a problem because it clashes with another module with the same
> >name in hardware monitors.
> >This patch renames the vexpress regulator implementation to
> >vexpress-regulator so that there will be no clash in the module namespace.
> Can you take this patch for v4.6 ? It was reported @[1]
Please allow a reasonable time for review. People get busy, go on
holiday, attend conferences and so on so unless there is some reason for
urgency (like critical bug fixes) please allow at least a couple of
weeks for review. Sending content free pings just adds to the mail
volume (if they are seen at all) and if something has gone wrong you'll
have to resend the patches anyway.
> [1] https://lkml.org/lkml/2016/1/29/7
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: vexpress: rename vexpress regulator implementation
2016-02-15 18:10 ` Mark Brown
@ 2016-02-15 18:12 ` Mark Brown
2016-02-15 18:31 ` Sudeep Holla
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2016-02-15 18:12 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-kernel, Rusty Russell, Liviu Dudau, Lorenzo Pieralisi,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Mon, Feb 15, 2016 at 06:10:17PM +0000, Mark Brown wrote:
> On Wed, Feb 10, 2016 at 06:49:54PM +0000, Sudeep Holla wrote:
> > [1] https://lkml.org/lkml/2016/1/29/7
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
...plus if you're using lkml.org it fails so often that it's likely
people won't be able to tell what you're talking about anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: vexpress: rename vexpress regulator implementation
2016-02-15 18:10 ` Mark Brown
2016-02-15 18:12 ` Mark Brown
@ 2016-02-15 18:31 ` Sudeep Holla
2016-02-15 21:00 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Sudeep Holla @ 2016-02-15 18:31 UTC (permalink / raw)
To: Mark Brown
Cc: Sudeep Holla, linux-kernel, Rusty Russell, Liviu Dudau,
Lorenzo Pieralisi, Liam Girdwood
On 15/02/16 18:10, Mark Brown wrote:
> On Wed, Feb 10, 2016 at 06:49:54PM +0000, Sudeep Holla wrote:
>> On 29/01/16 17:37, Sudeep Holla wrote:
>
>>> The vexpress regulator implementation is currently just called vexpress.
>>> This is a problem because it clashes with another module with the same
>>> name in hardware monitors.
>
>>> This patch renames the vexpress regulator implementation to
>>> vexpress-regulator so that there will be no clash in the module namespace.
>
>> Can you take this patch for v4.6 ? It was reported @[1]
>
> Please allow a reasonable time for review. People get busy, go on
> holiday, attend conferences and so on so unless there is some reason for
> urgency (like critical bug fixes) please allow at least a couple of
> weeks for review. Sending content free pings just adds to the mail
> volume (if they are seen at all) and if something has gone wrong you'll
> have to resend the patches anyway.
>
Sorry for that. It was not a ping rather I just wanted to provide the
reference for the report since I realized I missed that initially.
I just asked the question along with that and didn't mean to show any
urgency. I do understand this patch is clearly not at all an urgent/
critical fix.
>> [1] https://lkml.org/lkml/2016/1/29/7
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
>
Understood. I knew lkml.org is broken if we tried very old links but
expected to work at-least for couple of month old patches. Anyways
hopefully [1] still works.
--
Regards,
Sudeep
[1] http://www.spinics.net/lists/linux-crypto/msg18316.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: vexpress: rename vexpress regulator implementation
2016-02-15 18:31 ` Sudeep Holla
@ 2016-02-15 21:00 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2016-02-15 21:00 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-kernel, Rusty Russell, Liviu Dudau, Lorenzo Pieralisi,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Mon, Feb 15, 2016 at 06:31:29PM +0000, Sudeep Holla wrote:
> Understood. I knew lkml.org is broken if we tried very old links but
> expected to work at-least for couple of month old patches. Anyways
> hopefully [1] still works.
It's not old links in particular AFAICT, just general instability.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-15 21:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-29 17:37 [PATCH] regulator: vexpress: rename vexpress regulator implementation Sudeep Holla
2016-02-10 18:49 ` Sudeep Holla
2016-02-15 18:10 ` Mark Brown
2016-02-15 18:12 ` Mark Brown
2016-02-15 18:31 ` Sudeep Holla
2016-02-15 21:00 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox