From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752035AbcBPBWg (ORCPT ); Mon, 15 Feb 2016 20:22:36 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:34417 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978AbcBPBWe (ORCPT ); Mon, 15 Feb 2016 20:22:34 -0500 Subject: Re: [PATCH v8 1/5] mfd: hi655x: Add document for mfd hi665x PMIC To: Lee Jones , References: <1455431363-113771-1-git-send-email-puck.chen@hisilicon.com> <1455431363-113771-2-git-send-email-puck.chen@hisilicon.com> <20160215083204.GD3455@x1> CC: , , , , , , , From: Chen Feng Message-ID: <56C279B3.80300@hisilicon.com> Date: Tue, 16 Feb 2016 09:21:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160215083204.GD3455@x1> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.193.64] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.56C279C2.012D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8d5418b1e4630fb854d2546ad0ba2f98 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lee, Thanks for your review. On 2016/2/15 16:32, Lee Jones wrote: > On Sun, 14 Feb 2016, Chen Feng wrote: > >> DT bindings for hisilicon hi655x MFD PMIC chip. >> >> Signed-off-by: Chen Feng >> Signed-off-by: Fei Wang >> Signed-off-by: Xinwei Kong >> Reviewed-by: Haojian Zhuang >> --- >> .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 27 ++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt > > For my own reference: > Acked-by: Lee Jones > Will you merge this into your git-repo? git git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git I saw mark already merged the part of regulator into his git tree. Hi Wei, Could you help merge the DTS part of these patch sets. >> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt >> new file mode 100644 >> index 0000000..0548569 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt >> @@ -0,0 +1,27 @@ >> +Hisilicon Hi655x Power Management Integrated Circuit (PMIC) >> + >> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220. >> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI. >> +We can use memory-mapped I/O to communicate. >> + >> ++----------------+ +-------------+ >> +| | | | >> +| Hi6220 | SSI bus | Hi655x | >> +| |-------------| | >> +| |(REGMAP_MMIO)| | >> ++----------------+ +-------------+ >> + >> +Required properties: >> +- compatible: Should be "hisilicon,hi655x-pmic". >> +- reg: Base address of PMIC on Hi6220 SoC. >> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain). >> +- pmic-gpios: The GPIO used by PMIC IRQ. >> + >> +Example: >> + pmic: pmic@f8000000 { >> + compatible = "hisilicon,hi655x-pmic"; >> + reg = <0x0 0xf8000000 0x0 0x1000>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; >> + } >