From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbcBPBcc (ORCPT ); Mon, 15 Feb 2016 20:32:32 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:38591 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcBPBca (ORCPT ); Mon, 15 Feb 2016 20:32:30 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 3/3] spi: rockchip: add debug interface support To: Mark Brown References: <1455524848-2646-1-git-send-email-shawn.lin@rock-chips.com> <1455524902-2780-1-git-send-email-shawn.lin@rock-chips.com> <20160215172632.GQ18988@sirena.org.uk> Cc: shawn.lin@rock-chips.com, shawn.lin@kernel-upstream.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: <56C27C27.8090108@rock-chips.com> Date: Tue, 16 Feb 2016 09:32:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160215172632.GQ18988@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 2016/2/16 1:26, Mark Brown wrote: > On Mon, Feb 15, 2016 at 04:28:22PM +0800, Shawn Lin wrote: > >> +#ifdef CONFIG_DEBUG_FS >> +#include >> +#endif > > Just include the header. Only add ifdefs if they do something. > >> +static int rockchip_spi_debugfs_init(struct rockchip_spi *rs) >> +{ >> + rs->debugfs = debugfs_create_dir("rockchip_spi", NULL); >> + if (!rs->debugfs) >> + return -ENOMEM; >> + >> + debugfs_create_file("regs", S_IFREG | S_IRUGO, >> + rs->debugfs, (void *)rs, &rockchip_spi_dbg_ops); >> + return 0; >> +} > > This is completely separate to the core debugfs support for SPI, if > we're adding new debugfs stuff that's per device we should be extending > the core debugfs stuff so everything is in one place. yes, I will check the spi core debugfs to see how we can extend it for per device to dump specific msg. Thanks. > > Your register dump stuff looks like you might want to consider using > regmap, it's got this and other register access diagnostics already. > -- Best Regards Shawn Lin