From: Aaron Lu <aaron.lu@intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular
Date: Tue, 16 Feb 2016 10:52:15 +0800 [thread overview]
Message-ID: <56C28EDF.9010804@intel.com> (raw)
In-Reply-To: <1455514071-26368-4-git-send-email-paul.gortmaker@windriver.com>
On 02/15/2016 01:27 PM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/acpi/Kconfig:config CRC_PMIC_OPREGION
> drivers/acpi/Kconfig: bool "ACPI operation region support for CrystalCove PMIC"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple modular references, so that when reading
> the driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: Aaron Lu <aaron.lu@intel.com>
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Aaron Lu <aaron.lu@intel.com>
Initially I want to make it a module, but then people told me it's not
safe to remove operation region handler during runtime, so it became
always builtin. We can change it back to module once the above problem
is solved.
next prev parent reply other threads:[~2016-02-16 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 5:27 [PATCH 0/3] acpi: remove modular references from non modular code Paul Gortmaker
2016-02-15 5:27 ` [PATCH 1/3] drivers/acpi: make bgrt driver explicitly non-modular Paul Gortmaker
2016-02-15 5:27 ` [PATCH 2/3] drivers/acpi: make apei/ghes.c more " Paul Gortmaker
2016-02-15 5:27 ` [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c " Paul Gortmaker
2016-02-16 2:52 ` Aaron Lu [this message]
2016-02-17 2:27 ` Zheng, Lv
2016-02-16 19:29 ` [PATCH 0/3] acpi: remove modular references from non modular code Rafael J. Wysocki
2016-02-17 2:24 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C28EDF.9010804@intel.com \
--to=aaron.lu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox