From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Sergio Prado <sergio.prado@e-labworks.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
nicolas.ferre@atmel.com, davem@davemloft.net,
gregory.clement@free-electrons.com, narmstrong@baylibre.com,
michal.simek@xilinx.com, harini.katakam@xilinx.com,
boris.brezillon@free-electrons.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: macb: make magic-packet property generic
Date: Tue, 16 Feb 2016 17:23:47 +0300 [thread overview]
Message-ID: <56C330F3.3090400@cogentembedded.com> (raw)
In-Reply-To: <1455581638-27771-1-git-send-email-sergio.prado@e-labworks.com>
Hello.
On 2/16/2016 3:13 AM, Sergio Prado wrote:
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
> As requested by Rob Herring on patch
> https://patchwork.ozlabs.org/patch/580862/
> ---
> Documentation/devicetree/bindings/net/macb.txt | 2 +-
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index c6b1cb5ffa87..b5a42df4c928 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -25,7 +25,7 @@ Required properties:
>
> Optional properties for PHY child node:
> - reset-gpios : Should specify the gpio for phy reset
> -- cdns,magic-packet : If present, indicates that the hardware supports waking
> +- magic-packet : If present, indicates that the hardware supports waking
> up via magic packet.
>
> Examples:
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 69af049e55a8..7ccf2298a5fa 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2929,7 +2929,7 @@ static int macb_probe(struct platform_device *pdev)
> bp->jumbo_max_len = macb_config->jumbo_max_len;
>
> bp->wol = 0;
> - if (of_get_property(np, "cdns,magic-packet", NULL))
> + if (of_get_property(np, "magic-packet", NULL))
Could as well use of_property_read_bool().
[...]
MBR, Sergei
prev parent reply other threads:[~2016-02-16 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 0:13 [PATCH net-next] net: macb: make magic-packet property generic Sergio Prado
2016-02-16 9:12 ` Arnd Bergmann
2016-02-16 14:23 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C330F3.3090400@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=harini.katakam@xilinx.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergio.prado@e-labworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).