From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932989AbcBPPtO (ORCPT ); Tue, 16 Feb 2016 10:49:14 -0500 Received: from mga02.intel.com ([134.134.136.20]:34629 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932199AbcBPPtN (ORCPT ); Tue, 16 Feb 2016 10:49:13 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="48766130" Subject: Re: [PATCHv2 19/28] thp: run vma_adjust_trans_huge() outside i_mmap_rwsem To: "Kirill A. Shutemov" , Hugh Dickins , Andrea Arcangeli , Andrew Morton References: <1455200516-132137-1-git-send-email-kirill.shutemov@linux.intel.com> <1455200516-132137-20-git-send-email-kirill.shutemov@linux.intel.com> Cc: Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Jerome Marchand , Yang Shi , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Dave Hansen Message-ID: <56C344F7.8070107@intel.com> Date: Tue, 16 Feb 2016 07:49:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455200516-132137-20-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 06:21 AM, Kirill A. Shutemov wrote: > vma_addjust_trans_huge() splits pmd if it's crossing VMA boundary. > During split we munlock the huge page which requires rmap walk. > rmap wants to take the lock on its own. Ahhh, ... so we $SUBJECT in order to fix it. Now it all makes sense. Maybe I'm old fashioned, but I tend to have forgotten $SUBJECT by the time I start to read the patch body text. It's really handy for me when the body text stands on its own.