From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbcBPQd6 (ORCPT ); Tue, 16 Feb 2016 11:33:58 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34140 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465AbcBPQdo (ORCPT ); Tue, 16 Feb 2016 11:33:44 -0500 Subject: Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support To: Michal Simek , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Nicolas Pitre References: <67c9013fc61f53515934b54847a05df8b8e1504a.1455552315.git.michal.simek@xilinx.com> <23ab10a19b21df2ef17a5bb6ce2a70d2d3fd3551.1455552315.git.michal.simek@xilinx.com> Cc: =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , monstr@monstr.eu, Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Greg Kroah-Hartman From: Peter Hurley Message-ID: <56C34F65.1040506@hurleysoftware.com> Date: Tue, 16 Feb 2016 08:33:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <23ab10a19b21df2ef17a5bb6ce2a70d2d3fd3551.1455552315.git.michal.simek@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On 02/15/2016 08:05 AM, Michal Simek wrote: > Support early console setup via DT for all listed compatible strings. > > Signed-off-by: Michal Simek > --- > > drivers/tty/serial/xilinx_uartps.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index 009e0dbc12d2..6f5657766815 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -1094,6 +1094,9 @@ static int __init cdns_early_console_setup(struct earlycon_device *device, > return 0; > } > EARLYCON_DECLARE(cdns, cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns_a, "xlnx,xuartps", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns_b, "cdns,uart-r1p8", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns_c, "cdns,uart-r1p12", cdns_early_console_setup); Earlycon now shares a common framework in linux-next. The EARLYCON_DECLARE() can be deleted and the OF_EARLYCON_DECLARE() can all share the same earlycon name. iow, -EARLYCON_DECLARE(cdns, cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); Regards, Peter Hurley > /** > * cdns_uart_console_write - perform write operation >