From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754756AbcBPUCw (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 15:02:52 -0500
Received: from mout.web.de ([212.227.15.4]:61113 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752584AbcBPUCu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 15:02:50 -0500
Subject: Re: coccinelle: also catch kzfree() issues
To: Julia Lawall <julia.lawall@lip6.fr>
References: <cover.1455638829.git.ydroneaud@opteya.com>
 <326298cef17f5109dc7b08094901aa1c69be83d5.1455638829.git.ydroneaud@opteya.com>
 <alpine.DEB.2.10.1602161815190.2685@hadrien>
Cc: Yann Droneaud <ydroneaud@opteya.com>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>,
        Tejun Heo <tj@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>, cocci@systeme.lip6.fr,
        linux-kernel@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <56C38049.7090205@users.sourceforge.net>
Date: Tue, 16 Feb 2016 21:02:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1602161815190.2685@hadrien>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:sz/EFq2Mq8fTYUyJsvCI3ygQXZEdzuOV4glRje1OZR7JHMaC8AI
 tRRaAbNVYGZ5dAwnh4MN62eG3L2+lH1h5O2Jt9KrymH8YMxFjBOVfQEzOv2yROH3MSLVxyM
 137z0WpM07tqBW/nosHflCPH+V/CI7aguF2MF9uItBPwNdyEzn0S5TG5W2XAz7mmwtUtnC8
 JKyoJblzpE0T2CgRido5w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:QqlAAZ93lwA=:FPiYx7CysfTQY4jW5itlZX
 u84Sh/Sobf354zfEsROQBpL/LbpJvkMVAWai1yTY6xe8cYxEGKpmVUaM1W/NWm6sAmx2+HmjW
 NJTIWN0sdfqNyQjSHoguyi0HIuG1BgfcjlLM4PzB0jxflVzu7xizTGl0nPC0l9q9TUv9qloP8
 AWHcIRE6U1OWWqxa3J5EfYrJFp/+ioQN/lt7mCFMnsDfSGraiiISy1K25VCJ743A/mHRuyS5g
 1jFJHhvxlGkTnZiC3p8uFrepNkF7Zo4+4KUW5cP8EJcjRGRurtUknMIGMvbyVGQ59B1fMNNRJ
 6dHI1x+r9oHXU+G1sBgWOXkKs+XFiIAq+jF0n32jpIBpoVxOi5wnHdL27LIiqsfwuzk26MgQv
 NZQ45v10lgk6JH/ygIrSJN7MlgvHKD6H6v4ulSecv1FN2OC/nrBJaWm9pmwEo2WxlzcB74oyR
 eLu/h7mg91Z6mTElFGEwk1VtMXVeHJjSeZpnolLG0F4IfdcBKI3MNXrga9e99vpx1bea9ryMB
 C3MxMU9nRW4xyv291SETIQ00Zy4Ht8DzmY1cNuSYewvZ92dV00scjVgZOFR7o9uZwed622GmR
 ZfUZR+n8+Y8iYAHXlWwhZ19EgF8jte/R+u2f5nvE6JBPpN12ONCpRFfsrxAIdB8FWpicdb713
 7Y6cR4x15+uIh3FCtJGoa1RQ0mZ3lMBYwknYNg4kaWl/YhDSpzvnNL1DUlPBx3GL8USflhgcs
 AgvsnG8b/es/xqpmQCwtwVs0mcUz5TiqztR8MPin4LGui5zZG5xY3fm/o2Gi31VuFnVydGXkR
 K73IVxV
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>  @free@
>> +identifier kfree =~ "kz?free";
> 
> Thanks for the suggestions.  However, the regular expression is not such a
> good idea.

How much is such a SmPL constraint still usable then?


> Coccinelle doesn't make any optimizations based on regulat expressions.

Where can your software optimise the source code search?


> It would be better to put a disjunction with kfree and kzfree explicitly,
> as in the other cases.

What are the circumstances for corresponding benefits?

Regards,
Markus