From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964849AbcBQAUZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 19:20:25 -0500
Received: from mail-pa0-f54.google.com ([209.85.220.54]:35678 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933384AbcBQAUX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 19:20:23 -0500
Message-ID: <56C3BCC3.5020109@gmail.com>
Date: Tue, 16 Feb 2016 16:20:19 -0800
From: David Daney <ddaney.cavm@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
CC: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Andrew Bresticker <abrestic@chromium.org>,
        Aaro Koskinen <aaro.koskinen@iki.fi>, Arnd Bergmann <arnd@arndb.de>,
        devicetree@vger.kernel.org, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute
References: <56C214EE.5050200@cogentembedded.com> <1455561341-2071-1-git-send-email-xypron.glpk@gmx.de>
In-Reply-To: <1455561341-2071-1-git-send-email-xypron.glpk@gmx.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/15/2016 10:35 AM, Heinrich Schuchardt wrote:
> Downstream packages like Debian flash-kernel rely on
> /proc/device-tree/model
> to determine how to install an updated kernel image.
>
> Most dts files provide this property.
>
> This patch adds a model attribute Octeon CPUs.
>
> v2:
> 	Use vendor prefix defined in vendor-prefixes.txt.
> 	Separate model from vendor by comma.
> 	Avoid wildcards.
>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>


NAK.

These device tree templates are only used on systems with archaic 
versions of u-boot.  For all modern OCTEON systems, the device tree is 
provided by the firmware and is not under the control of the authors of 
the Linux kernel.

Whatever problem you are attempting to solve, almost by definition, 
cannot be solved by modifying these files.

We are worse off changing these, and giving people false hope that you 
are fixing something, than doing nothing.

David Daney



> ---
>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> index 9c48e05..f70cd58 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-3860";
> +	model = "cavium,Octeon 3860";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu>;
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> index 79b46fc..0b40899 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-6880";
> +	model = "cavium,Octeon 6880";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu2>;
>