From: David Daney <ddaney.cavm@gmail.com>
To: Ioan Nicu <ioan.nicu.ext@nokia.com>,
Ralf Baechle <ralf@linux-mips.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: David Daney <david.daney@cavium.com>,
Aleksey Makarov <aleksey.makarov@auriga.com>,
Leonid Rosenboim <lrosenboim@caviumnetworks.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Uwe Duerr <uwe.duerr.ext@nokia.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Octeon: do not change affinity for disabled irqs
Date: Tue, 16 Feb 2016 17:15:16 -0800 [thread overview]
Message-ID: <56C3C9A4.1040109@gmail.com> (raw)
In-Reply-To: <20160215154513.GF25050@ulegcpding.emea.nsn-net.net>
On 02/15/2016 07:45 AM, Ioan Nicu wrote:
> Octeon sets the default irq affinity to value 1 in the early arch init
> code, so by default all irqs get registered with their affinity set to
> core 0.
>
> When setting one CPU ofline, octeon_irq_cpu_offline_ciu() calls
> irq_set_affinity_locked(), but this function sets the IRQD_AFFINITY_SET bit
> in the irq descriptor. This has the side effect that if one irq is
> requested later, after putting one CPU offline, the affinity of this irq
> would not be the default anymore, but rather forced to "all cores - the
> offline core".
>
> This patch sets the IRQCHIP_ONOFFLINE_ENABLED flag in octeon irq
> controllers, so that the kernel would call the irq_cpu_[on|off]line()
> callbacks only for enabled irqs. If some other irq is requested after
> setting one cpu offline, it would use the default irq affinity, same as it
> would do in the normal case where there is no CPU hotplug operation.
>
> Signed-off-by: Ioan Nicu <ioan.nicu.ext@nokia.com>
> Acked-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
In principle, I don't object.
I would like to see what tglx has to say about this though. If we are
worried about the IRQD_AFFINITY_SET bit, I am not convinced that this is
the best place to be tweaking code. Are we papering over something that
should be handled in a more general manner? I don't know.
David Daney
> ---
> arch/mips/cavium-octeon/octeon-irq.c | 15 ++++++++++++---
> 1 files changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> index 368eb49..684582e 100644
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -935,6 +935,7 @@ static struct irq_chip octeon_irq_chip_ciu_v2 = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity_v2,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -948,6 +949,7 @@ static struct irq_chip octeon_irq_chip_ciu_v2_edge = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity_v2,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -963,6 +965,7 @@ static struct irq_chip octeon_irq_chip_ciu_sum2 = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity_sum2,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -976,6 +979,7 @@ static struct irq_chip octeon_irq_chip_ciu_sum2_edge = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity_sum2,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -988,6 +992,7 @@ static struct irq_chip octeon_irq_chip_ciu = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -1001,6 +1006,7 @@ static struct irq_chip octeon_irq_chip_ciu_edge = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -1041,7 +1047,7 @@ static struct irq_chip octeon_irq_chip_ciu_gpio_v2 = {
> .irq_set_affinity = octeon_irq_ciu_set_affinity_v2,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> #endif
> - .flags = IRQCHIP_SET_TYPE_MASKED,
> + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_ONOFFLINE_ENABLED,
> };
>
> static struct irq_chip octeon_irq_chip_ciu_gpio = {
> @@ -1056,7 +1062,7 @@ static struct irq_chip octeon_irq_chip_ciu_gpio = {
> .irq_set_affinity = octeon_irq_ciu_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> #endif
> - .flags = IRQCHIP_SET_TYPE_MASKED,
> + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_ONOFFLINE_ENABLED,
> };
>
> /*
> @@ -1838,6 +1844,7 @@ static struct irq_chip octeon_irq_chip_ciu2 = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu2_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -1851,6 +1858,7 @@ static struct irq_chip octeon_irq_chip_ciu2_edge = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu2_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
> @@ -1886,7 +1894,7 @@ static struct irq_chip octeon_irq_chip_ciu2_gpio = {
> .irq_set_affinity = octeon_irq_ciu2_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> #endif
> - .flags = IRQCHIP_SET_TYPE_MASKED,
> + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_ONOFFLINE_ENABLED,
> };
>
> static int octeon_irq_ciu2_xlat(struct irq_domain *d,
> @@ -2537,6 +2545,7 @@ static struct irq_chip octeon_irq_chip_ciu3 = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu3_set_affinity,
> .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> + .flags = IRQCHIP_ONOFFLINE_ENABLED,
> #endif
> };
>
>
next prev parent reply other threads:[~2016-02-17 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 15:45 [PATCH] MIPS: Octeon: do not change affinity for disabled irqs Ioan Nicu
2016-02-17 1:15 ` David Daney [this message]
2016-03-30 8:48 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3C9A4.1040109@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aleksey.makarov@auriga.com \
--cc=alexander.sverdlin@nokia.com \
--cc=david.daney@cavium.com \
--cc=ioan.nicu.ext@nokia.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lrosenboim@caviumnetworks.com \
--cc=marc.zyngier@arm.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=uwe.duerr.ext@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox