From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756706AbcBQHGH (ORCPT ); Wed, 17 Feb 2016 02:06:07 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:22129 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756514AbcBQHGE (ORCPT ); Wed, 17 Feb 2016 02:06:04 -0500 X-AuditID: cbfec7f4-f79026d00000418a-f6-56c41bd87fb5 Subject: Re: [RFC 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 To: Viresh Kumar References: <1455692128-28504-1-git-send-email-k.kozlowski@samsung.com> <1455692128-28504-2-git-send-email-k.kozlowski@samsung.com> <20160217070105.GK2454@vireshk-i7> Cc: Kukjin Kim , Lukasz Majewski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <56C41BD3.3060202@samsung.com> Date: Wed, 17 Feb 2016 16:05:55 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160217070105.GK2454@vireshk-i7> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xa7o3pI+EGay6KGmxccZ6Vov5V66x Wrx5u4bJ4vULQ4v+x6+ZLd483MxosekxUPzyrjlsFp97jzBazDi/j8niycM+NouNXz0ceDx2 zrrL7rF4z0smj02rOtk87lzbw+axeUm9x5Z+oHjfllWMHp83yQVwRHHZpKTmZJalFunbJXBl TN9ylbngEnfFt987WRoY13J2MXJySAiYSLTtPMEIYYtJXLi3ng3EFhJYyijx/r94FyMXkP2U UeLbyTXMIAlhAS+J/ucfWLoYOThEBLQkXt5MhahfxSjx9pYeSD2zQAezxKk9C1hBEmwCxhKb ly8BG8oLVD/t52OwZSwCqhJvDv0CmykqECFxuLOLHaJGUOLH5HssIDangL5Ee8MdRpBdzAJ6 EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yf u4kREitfdjAuPmZ1iFGAg1GJhzcg43CYEGtiWXFl7iFGCQ5mJRFehudAId6UxMqq1KL8+KLS nNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTAGzp8yWfB/c/vFJB1L/1h5nhl+ l/RDbr2dHMx5/8Gudyn/tumJX9+cqBhZrX2huHiNbCVr3JMq2yT3GddDqsRT09VWZ8kdu7p/ 5inPz6HdPJppy0XO1gUE5CbHH3zAe35lcOUM7x8fmMLVnlrlh53sTiuSv/Z6k2NIZsG6/v06 l1SKXk65xqHEUpyRaKjFXFScCACPIy0hkQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.02.2016 16:01, Viresh Kumar wrote: > On 17-02-16, 15:55, Krzysztof Kozlowski wrote: >> On Exynos5420 we support 8 cpufreq steps (600-1300 MHz) for LITTLE and >> 12 steps for big core (700-1800 MHz). Add respective cooling cells. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/exynos5420-cpus.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi >> index 261d25173f61..498ae82e1cb2 100644 >> --- a/arch/arm/boot/dts/exynos5420-cpus.dtsi >> +++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi >> @@ -33,6 +33,9 @@ >> clock-frequency = <1800000000>; >> cci-control-port = <&cci_control1>; >> operating-points-v2 = <&cluster_a15_opp_table>; >> + cooling-min-level = <0>; >> + cooling-max-level = <11>; >> + #cooling-cells = <2>; /* min followed by max */ >> }; >> >> cpu1: cpu@1 { >> @@ -70,6 +73,9 @@ >> clock-frequency = <1000000000>; >> cci-control-port = <&cci_control0>; >> operating-points-v2 = <&cluster_a7_opp_table>; >> + cooling-min-level = <0>; >> + cooling-max-level = <7>; >> + #cooling-cells = <2>; /* min followed by max */ >> }; > > Though it wouldn't matter (for the issue you are getting), but this should be > added for all the CPUs in case some other CPU is booted first. Thanks! I'll fix it also for patch 2/3. Best regards, Krzysztof