From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934152AbcBQLAN (ORCPT ); Wed, 17 Feb 2016 06:00:13 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37143 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934013AbcBQLAL (ORCPT ); Wed, 17 Feb 2016 06:00:11 -0500 Subject: Re: [PATCHv4 3/7] eeprom: at24: extend driver to plug into the NVMEM framework To: Wolfram Sang References: <1455666097-9115-1-git-send-email-andrew@lunn.ch> <1455666097-9115-4-git-send-email-andrew@lunn.ch> <56C448C3.3060000@linaro.org> <20160217102113.GC1390@katana> Cc: Andrew Lunn , GregKH , maxime.ripard@free-electrons.com, broonie@kernel.org, vz@mleia.com, fd@ti.com, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com From: Srinivas Kandagatla Message-ID: <56C452B8.5090503@linaro.org> Date: Wed, 17 Feb 2016 11:00:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160217102113.GC1390@katana> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/16 10:21, Wolfram Sang wrote: > On Wed, Feb 17, 2016 at 10:17:39AM +0000, Srinivas Kandagatla wrote: >> >> >> On 16/02/16 23:41, Andrew Lunn wrote: >>> Add a regmap for accessing the EEPROM, and then use that with the >>> NVMEM framework. Set the NVMEM config structure to enable backward, so >>> that the 'eeprom' file in sys is provided by the framework. >>> >>> Signed-off-by: Andrew Lunn >> >> This patch looks good to me, Please feel free to add my Ack. > > Please provide a proper Acked-by. Tools like 'patchwork' collect them > automatically which means less manual work for me. Hint: Assign a > keyboard macro to your text editor for that. Agreed, I will take care of it next time.