From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423137AbcBQNpV (ORCPT ); Wed, 17 Feb 2016 08:45:21 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38166 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423065AbcBQNpS (ORCPT ); Wed, 17 Feb 2016 08:45:18 -0500 Subject: Re: [PATCHv4 5/7] eeprom: at25: extend driver to plug into the NVMEM framework To: Andrew Lunn References: <1455666097-9115-1-git-send-email-andrew@lunn.ch> <1455666097-9115-6-git-send-email-andrew@lunn.ch> <56C448CF.4070208@linaro.org> <20160217134240.GD17326@lunn.ch> Cc: GregKH , maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, vz@mleia.com, fd@ti.com, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com From: Srinivas Kandagatla Message-ID: <56C4796B.4030003@linaro.org> Date: Wed, 17 Feb 2016 13:45:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160217134240.GD17326@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/16 13:42, Andrew Lunn wrote: >>> - if (!(chip.flags & EE_READONLY)) { >>> - at25->bin.write = at25_bin_write; >>> - at25->bin.attr.mode |= S_IWUSR; >>> - } >> >> Above check is totally unused, probably remove it. > > Sorry, i don't understand. This check is being removed. Oops, it think I replied to wrong patch, this comment was intended for "[PATCH 6/7] eeprom: 93xx46: extend driver to plug into the NVMEM framework" --srini > > Thanks > Andrew >