From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>, GregKH <greg@kroah.com>
Cc: maxime.ripard@free-electrons.com, wsa@the-dreams.de,
broonie@kernel.org, vz@mleia.com, fd@ti.com,
linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com,
bgolaszewski@baylibre.com
Subject: Re: [PATCHv4 6/7] eeprom: 93xx46: extend driver to plug into the NVMEM framework
Date: Wed, 17 Feb 2016 13:46:50 +0000 [thread overview]
Message-ID: <56C479CA.5010308@linaro.org> (raw)
In-Reply-To: <1455666097-9115-7-git-send-email-andrew@lunn.ch>
On 16/02/16 23:41, Andrew Lunn wrote:
> if (!(pd->flags & EE_READONLY)) {
> - edev->bin.write = eeprom_93xx46_bin_write;
> - edev->bin.attr.mode |= S_IWUSR;
> }
>
Is this check really required?
--srini
next prev parent reply other threads:[~2016-02-17 13:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 23:41 [PATCHv4 0/7] Convert exiting EEPROM drivers to NVMEM Andrew Lunn
2016-02-16 23:41 ` [PATCHv4 1/7] nvmem: Add flag to export NVMEM to root only Andrew Lunn
2016-02-17 10:17 ` Srinivas Kandagatla
2016-02-17 13:32 ` Andrew Lunn
2016-02-16 23:41 ` [PATCHv4 2/7] nvmem: Add backwards compatibility support for older EEPROM drivers Andrew Lunn
2016-02-17 10:17 ` Srinivas Kandagatla
2016-02-17 13:27 ` Andrew Lunn
2016-02-16 23:41 ` [PATCHv4 3/7] eeprom: at24: extend driver to plug into the NVMEM framework Andrew Lunn
2016-02-17 10:17 ` Srinivas Kandagatla
2016-02-17 10:21 ` Wolfram Sang
2016-02-17 11:00 ` Srinivas Kandagatla
2016-02-17 11:00 ` Srinivas Kandagatla
2016-02-16 23:41 ` [PATCHv4 4/7] eeprom: at25: Remove in kernel API for accessing the EEPROM Andrew Lunn
2016-02-17 10:17 ` Srinivas Kandagatla
2016-02-16 23:41 ` [PATCHv4 5/7] eeprom: at25: extend driver to plug into the NVMEM framework Andrew Lunn
2016-02-17 10:17 ` Srinivas Kandagatla
2016-02-17 13:42 ` Andrew Lunn
2016-02-17 13:45 ` Srinivas Kandagatla
2016-02-16 23:41 ` [PATCHv4 6/7] eeprom: 93xx46: " Andrew Lunn
2016-02-17 10:17 ` Srinivas Kandagatla
2016-02-17 13:46 ` Srinivas Kandagatla [this message]
2016-02-16 23:41 ` [PATCHv4 7/7] misc: at24: replace memory_accessor with nvmem_device_read Andrew Lunn
2016-02-17 10:18 ` Srinivas Kandagatla
2016-02-17 10:17 ` [PATCHv4 0/7] Convert exiting EEPROM drivers to NVMEM Srinivas Kandagatla
2016-02-17 13:39 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C479CA.5010308@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=fd@ti.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox