From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965314AbcBQOQZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Feb 2016 09:16:25 -0500
Received: from mail-lf0-f51.google.com ([209.85.215.51]:35100 "EHLO
	mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964898AbcBQOQX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Feb 2016 09:16:23 -0500
Subject: Re: [PATCH] lance: Return correct error code
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20160217133516.GA31497@amitoj-Inspiron-3542>
Cc: julia.lawall@lip6.fr
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56C480B5.7000902@cogentembedded.com>
Date: Wed, 17 Feb 2016 17:16:21 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160217133516.GA31497@amitoj-Inspiron-3542>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 2/17/2016 4:35 PM, Amitoj Kaur Chawla wrote:

> The return value of kzalloc on failure should be -ENOMEM and

    kzalloc() returns NULL on failure! You need to clarify your patch 
description, so that it makes some sense.

> not -ENODEV.
>
> Additionally, removed the following checkpatch warnings:
> ERROR: spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> CHECK: Comparison to NULL could be written "!lp"
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
[...]

MBR, Sergei