Re: [PATCH v3 01/22] [media] Docbook: media-types.xml: Add ALSA Media Controller Intf types

Mauro Carvalho Chehab
2016-02-17T12:20:00Z

Em Thu, 11 Feb 2016 16:41:17 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:

> Add ALSA Media Controller Intf types
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Documentation/DocBook/media/v4l/media-types.xml | 40 +++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml
> index 751c3d0..3730967 100644
> --- a/Documentation/DocBook/media/v4l/media-types.xml
> +++ b/Documentation/DocBook/media/v4l/media-types.xml
> @@ -193,6 +193,46 @@
> <entry>Device node interface for Software Defined Radio (V4L)</entry>
> <entry>typically, /dev/swradio?</entry>
> </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_PCM_CAPTURE</constant></entry>
> + <entry>Device node interface for ASLA PCM Capture</entry>
> + <entry>typically, /dev/snd/pcmC?D?c</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_PCM_PLAYBACK</constant></entry>
> + <entry>Device node interface for ASLA PCM Playback</entry>
> + <entry>typically, /dev/snd/pcmC?D?p</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_CONTROL</constant></entry>
> + <entry>Device node interface for ASLA Control</entry>
> + <entry>typically, /dev/snd/controlC?</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_COMPRESS</constant></entry>
> + <entry>Device node interface for ASLA Compress</entry>
> + <entry>typically, /dev/snd/compr?</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_RAWMIDI</constant></entry>
> + <entry>Device node interface for ASLA Raw MIDI</entry>
> + <entry>typically, /dev/snd/midi?</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_HWDEP</constant></entry>
> + <entry>Device node interface for ASLA Hardware Dependent</entry>
> + <entry>typically, /dev/snd/hwC?D?</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_SEQUENCER</constant></entry>
> + <entry>Device node interface for ASLA Sequencer</entry>
> + <entry>typically, /dev/snd/seq</entry>
> + </row>
> + <row>
> + <entry><constant>MEDIA_INTF_T_ALSA_TIMER</constant></entry>
> + <entry>Device node interface for ASLA Timer</entry>
> + <entry>typically, /dev/snd/timer</entry>

On all the above:
s,ASLA,ALSA,

Except for that, patch looks OK for me.

Takashi,

If this is OK for you too, could you please ack?

Thanks,
Mauro