From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424822AbcBREmN (ORCPT ); Wed, 17 Feb 2016 23:42:13 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:29481 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424254AbcBREmL (ORCPT ); Wed, 17 Feb 2016 23:42:11 -0500 X-AuditID: cbfec7f4-f79026d00000418a-63-56c54ba0e5fc Subject: Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load To: Viresh Kumar References: <1455692128-28504-1-git-send-email-k.kozlowski@samsung.com> <1455692128-28504-4-git-send-email-k.kozlowski@samsung.com> <56C522A9.8070800@samsung.com> <20160218023622.GA2610@vireshk-i7> Cc: Anand Moon , Kukjin Kim , Lukasz Majewski , linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Linux PM list , Zhang Rui , Eduardo Valentin , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <56C54B9B.7030105@samsung.com> Date: Thu, 18 Feb 2016 13:42:03 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160218023622.GA2610@vireshk-i7> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42I5/e/4Zd0F3kfDDP7dErbYOGM9q8X8K9dY Ld68XcNk8fqFoUX/49fMFm8ebma02PQYKH551xw2i8+9RxgtZpzfx2SxbuMtdosnD/vYLDZ+ 9XDg9dg56y67x+I9L5k8Nq3qZPO4c20Pm8fmJfUeW/qB4n1bVjF6fN4kF8ARxWWTkpqTWZZa pG+XwJVxv2c7U8FMrooPV40bGN9ydDFyckgImEg8OjCVGcIWk7hwbz1bFyMXh5DAUkaJux83 MUM4Txkljt35zAhSJSwQIPFj/yX2LkYODhEBLYmXN1MhaiYwSSz/0wLWzSzwnVmi98dkNpAG NgFjic3Ll4DZvEANd4/tBVvHIqAqsePGHnYQW1QgQuJwZxc7RI2gxI/J91hAbE4BfYkls9ax gSxjFtCTuH9RCyTMLCAvsXnNW+YJjAKzkHTMQqiahaRqASPzKkbR1NLkguKk9FxDveLE3OLS vHS95PzcTYyQuPmyg3HxMatDjAIcjEo8vByvj4QJsSaWFVfmHmKU4GBWEuH95n40TIg3JbGy KrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTBycUg2Mc03fOUiIJn81yZ66 oFzHdPZJ10Tfs45Hzm65u/1X2gJrdSfTLdya3OzxGl9qnfct/R+66PgB9ysbT+wREXxxK7tk o/qc35XOjByV10POX5PpslW8xySo1fHvgqvLzVfxp4NFl9zccIZn/kaXhJuXTkwXkQr7duwG U+LfhKMMtpf3M3z1Pymko8RSnJFoqMVcVJwIAIRacLCXAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.02.2016 11:36, Viresh Kumar wrote: >> >> BTW, I found the issue. The order of trip points in DT: >> thermal_zone0/trip_point_0_hyst:5000 >> thermal_zone0/trip_point_0_temp:50000 >> thermal_zone0/trip_point_0_type:active >> thermal_zone0/trip_point_1_hyst:5000 >> thermal_zone0/trip_point_1_temp:60000 >> thermal_zone0/trip_point_1_type:active >> thermal_zone0/trip_point_2_hyst:5000 >> thermal_zone0/trip_point_2_temp:70000 >> thermal_zone0/trip_point_2_type:active >> thermal_zone0/trip_point_3_hyst:0 >> thermal_zone0/trip_point_3_temp:120000 <---- this should be last one! >> thermal_zone0/trip_point_3_type:critical >> thermal_zone0/trip_point_4_hyst:5000 >> thermal_zone0/trip_point_4_temp:90000 >> thermal_zone0/trip_point_4_type:passive >> thermal_zone0/trip_point_5_hyst:5000 >> thermal_zone0/trip_point_5_temp:110000 >> thermal_zone0/trip_point_5_type:passive >> >> After fixing the order in DT, the cpu cooler starts working. > > Ahh, nice. Damn, not entirely. I almost fried my Odroid (it survived 130 degrees of C)... The TMU supports only 4 trip points, so when I added two new trip points and reordered them... the last two (including critical) was not receiving interrupts. Polling mode is needed. I'll sent some patches soon... BR, Krzysztof