From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425138AbcBRFcJ (ORCPT ); Thu, 18 Feb 2016 00:32:09 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:58672 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424699AbcBRFcE (ORCPT ); Thu, 18 Feb 2016 00:32:04 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79646d000001316-c1-56c55750f5f1 Content-transfer-encoding: 8BIT Message-id: <56C5574F.7090900@samsung.com> Date: Thu, 18 Feb 2016 14:31:59 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Lukasz Majewski , Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org Cc: Viresh Kumar Subject: Re: [PATCH 3/3] thermal: exynos: Print a message about exceeded number of supported trip-points References: <1455772460-20684-1-git-send-email-k.kozlowski@samsung.com> <1455772460-20684-3-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1455772460-20684-3-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkQDcg/GiYwZ01Qhbzj5xjtZh/5Rqr xesXhhb9j18zW7x5uJnRYtNjoNDlXXPYLD73HmG0mHF+H5PFk4d9bBYbv3o4cHvsnHWX3WPx npdMHptWdbJ53Lm2h81j85J6j74tqxg9Pm+SC2CP4rJJSc3JLEst0rdL4Mo4MK2BqaBdqeL8 oZusDYyfpLsYOTgkBEwkXi0I7WLkBDLFJC7cW8/WxcjFISSwglHi8v5fLBAJE4mlyxcxQiSW Mkpc332VGSTBKyAo8WPyPRaQQcwC8hJHLmWDhJkF1CUmzVsEViIk8IBRYukkF4hyLYnVf/aA zWQRUJXo/d/BBGKzAcX3v7jBBjJGVCBCovtEJcgqEYFXTBKPX19hhJipJbH29G2wmcICWRIt Cy9B3dPKKLHyyAtWkGZOAQ+JUy/TQeISAn/ZJT71TIJaJiDxbfIhFoiHZSU2HWCG+EtS4uCK GywTGMVmIflmFsI3s5B8s4CReRWjaGpBckFxUnqRiV5xYm5xaV66XnJ+7iZGYJye/vdswg7G ewesDzEKcDAq8fByvD4SJsSaWFZcmXuI0RToiInMUqLJ+cBkkFcSb2hsZmRhamJqbGRuaaYk zvta6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsbY1V85JyesuyCpsSGqrWdp5ez5xT27 HNQuSa/QeeVSMWXlKdmHL5X60+5t7C//EFAty6zT3D9z/sEPO8onNFgIh67WeXTq905e5oef e9paTarSpJef2n/uzn5O/5Pv/XSuvvL9vubchUVhS803T68P+Oeg93LZiwRZzluHwkrv9xmI ODj+t9FRYinOSDTUYi4qTgQAW9Rzhs4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e+xgG5A+NEwg3fPuC3mHznHajH/yjVW i9cvDC36H79mtnjzcDOjxabHQKHLu+awWXzuPcJoMeP8PiaLJw/72Cw2fvVw4PbYOesuu8fi PS+ZPDat6mTzuHNtD5vH5iX1Hn1bVjF6fN4kF8Ae1cBok5GamJJapJCal5yfkpmXbqvkHRzv HG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQN0opJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd 35AguB4jAzSQsIYx48C0BqaCdqWK84dusjYwfpLuYuTkkBAwkVi6fBEjhC0mceHeerYuRi4O IYGljBLXd19lBknwCghK/Jh8j6WLkYODWUBe4silbJAws4C6xKR5i8BKhAQeMEosneQCUa4l sfrPHhYQm0VAVaL3fwcTiM0GFN//4gYbyBhRgQiJ7hOVIKtEBF4xSTx+fYURYqaWxNrTt8Fm CgtkSbQsvMQIcU8ro8TKIy9YQZo5BTwkTr1Mn8AoMAvJdbMQrpuF5LoFjMyrGCVSC5ILipPS c43yUsv1ihNzi0vz0vWS83M3MYKTwTPpHYyHd7kfYhTgYFTi4eV4fSRMiDWxrLgy9xCjBAez kgjvN/ejYUK8KYmVValF+fFFpTmpxYcYTYH+m8gsJZqcD0xUeSXxhsYmZkaWRuaGFkbG5kri vI//rwsTEkhPLEnNTk0tSC2C6WPi4JRqYJz4bsKkWTLd0iVaJtKmF+OFFi977Z9o77rGjEVT dGKrdticF8G8U1gdBa4vr5hoIKr+rHP1m8/vMi20zHxK38tlx6W9XXv+3JmDj+P05VdpfOYo /ZaaMrO2cGK74qYtG+0imkzqttt1P961xFrJZ9Hhgs/VseoPay/9T85OtPSymKZ/53rRdyWW 4oxEQy3mouJEAK0pxnAcAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 02월 18일 14:14, Krzysztof Kozlowski wrote: > When DeviveTree contains more trip-points than SoC can configure > (usually more than four) and polling mode is not enabled, then the > remaining trip-points will be silently ignored. No interrupts will be > generated for them. > > This might be quite dangerous when one provides DTB with a > non-configurable critical trip-point, like (assuming four supported > thresholds in TMU): > - alert @50 C (type: active), > - alert @60 C (type: active), > - alert @70 C (type: active), > - alert @80 C (type: active), > - critical @120 C (type: critical) <- no interrupts generated. > > This is a mistake in DTB so print a message in such case. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/thermal/samsung/exynos_tmu.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index fa61eff88496..6c6f59ba7423 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -184,6 +184,7 @@ > * @temp_error2: fused value of the second point trim. > * @regulator: pointer to the TMU regulator structure. > * @reg_conf: pointer to structure to register with core thermal. > + * @ntrip: number of supported trip points. > * @tmu_initialize: SoC specific TMU initialization method > * @tmu_control: SoC specific TMU control method > * @tmu_read: SoC specific TMU temperature read method > @@ -203,6 +204,7 @@ struct exynos_tmu_data { > u16 temp_error1, temp_error2; > struct regulator *regulator; > struct thermal_zone_device *tzd; > + unsigned int ntrip; > > int (*tmu_initialize)(struct platform_device *pdev); > void (*tmu_control)(struct platform_device *pdev, bool on); > @@ -346,6 +348,14 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > struct exynos_tmu_data *data = platform_get_drvdata(pdev); > int ret; > > + if (of_thermal_get_ntrips(data->tzd) > data->ntrip) { > + dev_info(&pdev->dev, > + "More trip points than supported by this TMU.\n"); > + dev_info(&pdev->dev, > + "%d trip points should be configured in polling mode.\n", > + (of_thermal_get_ntrips(data->tzd) - data->ntrip)); > + } > + > mutex_lock(&data->lock); > clk_enable(data->clk); > if (!IS_ERR(data->clk_sec)) > @@ -1210,6 +1220,7 @@ static int exynos_map_dt_data(struct platform_device *pdev) > data->tmu_control = exynos4210_tmu_control; > data->tmu_read = exynos4210_tmu_read; > data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; > + data->ntrip = 4; > break; > case SOC_ARCH_EXYNOS3250: > case SOC_ARCH_EXYNOS4412: > @@ -1222,6 +1233,7 @@ static int exynos_map_dt_data(struct platform_device *pdev) > data->tmu_read = exynos4412_tmu_read; > data->tmu_set_emulation = exynos4412_tmu_set_emulation; > data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; > + data->ntrip = 4; > break; > case SOC_ARCH_EXYNOS5433: > data->tmu_initialize = exynos5433_tmu_initialize; > @@ -1229,6 +1241,7 @@ static int exynos_map_dt_data(struct platform_device *pdev) > data->tmu_read = exynos4412_tmu_read; > data->tmu_set_emulation = exynos4412_tmu_set_emulation; > data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; > + data->ntrip = 8; > break; > case SOC_ARCH_EXYNOS5440: > data->tmu_initialize = exynos5440_tmu_initialize; > @@ -1236,6 +1249,7 @@ static int exynos_map_dt_data(struct platform_device *pdev) > data->tmu_read = exynos5440_tmu_read; > data->tmu_set_emulation = exynos5440_tmu_set_emulation; > data->tmu_clear_irqs = exynos5440_tmu_clear_irqs; > + data->ntrip = 4; > break; > case SOC_ARCH_EXYNOS7: > data->tmu_initialize = exynos7_tmu_initialize; > @@ -1243,6 +1257,7 @@ static int exynos_map_dt_data(struct platform_device *pdev) > data->tmu_read = exynos7_tmu_read; > data->tmu_set_emulation = exynos4412_tmu_set_emulation; > data->tmu_clear_irqs = exynos4210_tmu_clear_irqs; > + data->ntrip = 8; > break; > default: > dev_err(&pdev->dev, "Platform not supported\n"); > Exynos5433 and Exynos7 have the 8 interrupt. Reviewed-by: Chanwoo Choi Best Regards, Chanwoo Choi