From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425790AbcBRJHx (ORCPT ); Thu, 18 Feb 2016 04:07:53 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33615 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425281AbcBRJHs (ORCPT ); Thu, 18 Feb 2016 04:07:48 -0500 Subject: Re: [PATCH] nvmem: core: fix error path in nvmem_add_cells() To: Rasmus Villemoes References: <1454965469-6141-1-git-send-email-linux@rasmusvillemoes.dk> <56C45016.2010806@linaro.org> <87wpq2h971.fsf@rasmusvillemoes.dk> Cc: Maxime Ripard , Greg Kroah-Hartman , linux-kernel@vger.kernel.org From: Srinivas Kandagatla Message-ID: <56C589DD.500@linaro.org> Date: Thu, 18 Feb 2016 09:07:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87wpq2h971.fsf@rasmusvillemoes.dk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/16 05:35, Rasmus Villemoes wrote: > On Wed, Feb 17 2016, Srinivas Kandagatla wrote: > >>> err: >>> - while (--i) >>> + while (i--) >> This is what you need here to fix it correctly. >> >> while (--i >= 0) >> > > Sigh. http://thread.gmane.org/gmane.linux.kernel.mm/146058/focus=2149595 Yes, You are correct! :-) I will queue this patch. --srini > > TL;DR: They're equivalent. > > Rasmus >