From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426005AbcBRJ6H (ORCPT ); Thu, 18 Feb 2016 04:58:07 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:40117 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425979AbcBRJ6C (ORCPT ); Thu, 18 Feb 2016 04:58:02 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: jay.xu@rock-chips.com X-FST-TO: devicetree@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: jay.xu@rock-chips.com X-UNIQUE-TAG: <709b76fb5dd325618aa169f95410bdca> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi To: Heiko Stuebner , Mark Brown References: <1455762983-29980-1-git-send-email-jay.xu@rock-chips.com> <1455762983-29980-3-git-send-email-jay.xu@rock-chips.com> <20160218094108.GA7129@sirena.org.uk> <2327512.KAqs6H56Km@phil> Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jwerner@chromium.org, catalin.marinas@arm.com, will.deacon@arm.com, sboyd@codeaurora.org, linus.walleij@linaro.org, sjoerd.simons@collabora.co.uk, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org From: Jianqun Xu Message-ID: <56C5959D.3030806@rock-chips.com> Date: Thu, 18 Feb 2016 17:57:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <2327512.KAqs6H56Km@phil> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko Thank you for you kindly explain, now I got your comments. ÔÚ 18/02/2016 17:47, Heiko Stuebner дµÀ: > From: Xu Jianqun > > Add devicetree bindings for Rockchip rk3399 spi which found on > Rockchip rk3399 SoCs. > > Signed-off-by: Jianqun Xu > Signed-off-by: Heiko Stuebner > --- > Hi Jianqun, > what Mark means is the following. > > Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 + > drivers/spi/spi-rockchip.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > index 0c491bd..1b14d69 100644 > --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > @@ -9,6 +9,7 @@ Required Properties: > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > + "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > - reg: physical base address of the controller and length of memory mapped > region. > - interrupts: The interrupt number to the cpu. The interrupt specifier format > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > index 79a8bc4..345fefd 100644 > --- a/drivers/spi/spi-rockchip.c > +++ b/drivers/spi/spi-rockchip.c > @@ -868,6 +868,7 @@ static const struct of_device_id rockchip_spi_dt_match[] = { > { .compatible = "rockchip,rk3066-spi", }, > { .compatible = "rockchip,rk3188-spi", }, > { .compatible = "rockchip,rk3288-spi", }, > + { .compatible = "rockchip,rk3399-spi", }, I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set the compatible like: - compatible: should be one of the followings - "rockchip,rk3066-i2s": for rk3066 - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188 - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288 - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399 and the driver only has static const struct of_device_id rockchip_i2s_match[] = { { .compatible = "rockchip,rk3066-i2s", }, {}, }; The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are keep different rules ? > { }, > }; > MODULE_DEVICE_TABLE(of, rockchip_spi_dt_match); >