From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945933AbcBRJ7g (ORCPT ); Thu, 18 Feb 2016 04:59:36 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:42826 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425960AbcBRJ72 (ORCPT ); Thu, 18 Feb 2016 04:59:28 -0500 X-AuditID: cbfec7f4-f79026d00000418a-f9-56c595fd9897 Subject: Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load To: Krzysztof Kozlowski , Viresh Kumar References: <1455692128-28504-1-git-send-email-k.kozlowski@samsung.com> <1455692128-28504-4-git-send-email-k.kozlowski@samsung.com> <56C522A9.8070800@samsung.com> <20160218023622.GA2610@vireshk-i7> <56C54B9B.7030105@samsung.com> Cc: Anand Moon , Kukjin Kim , Lukasz Majewski , linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Linux PM list , Zhang Rui , Eduardo Valentin , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas From: Marek Szyprowski Message-id: <56C595F7.1080406@samsung.com> Date: Thu, 18 Feb 2016 10:59:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56C54B9B.7030105@samsung.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42I5/e/4Nd2/U4+GGbTM1bTYOGM9q8X8K9dY Ld68XcNk8fqFoUX/49fMFm8ebma02PQYKH551xw2i8+9RxgtZpzfx2SxbuMtdosnD/vYLDZ+ 9XDg9dg56y67x+I9L5k8Nq3qZPO4c20Pm8fmJfUeW/qB4n1bVjF6fN4kF8ARxWWTkpqTWZZa pG+XwJVxZ+8m5oK9PBV75zUwNTA+5Opi5OSQEDCRuPC9hxHCFpO4cG89G4gtJLCUUeJzj3UX IxeQ/ZxRomniZ1aQhLBAgMSP/ZfYQWwRgWiJq9N3skA0bGSS6D8G1sAs8J1ZovfHZLBJbAKG El1vu8BsXgEtiTMnPoI1sAioSvzfNBlss6hAjMTFziNMEDWCEj8m3wOr4RTQlth94wbYMmYB M4kvLw+zQtjyEpvXvGWewCgwC0nLLCRls5CULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yf u4kREjtfdjAuPmZ1iFGAg1GJh5fj9ZEwIdbEsuLK3EOMEhzMSiK8dZOPhgnxpiRWVqUW5ccX leakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBUSnEWPhM36uqtzcvVy6Ym7Yv 6JfK4jfv9S4dULmtuvbwYaOdXzN38BnMmvyzjdnuivX3jwzFVR9UHrfFcB552cg9JeyTgOXL e9oLGjPcT+az1Il/nXvIMFdalmmdWCe79ct6iZ/Zp+znq7/7s8fEYqH40bwu6UPaV/8rLbGa fdHMqO/sXtdTmUosxRmJhlrMRcWJAMsH+ECZAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2016-02-18 05:42, Krzysztof Kozlowski wrote: > On 18.02.2016 11:36, Viresh Kumar wrote: >>> BTW, I found the issue. The order of trip points in DT: >>> thermal_zone0/trip_point_0_hyst:5000 >>> thermal_zone0/trip_point_0_temp:50000 >>> thermal_zone0/trip_point_0_type:active >>> thermal_zone0/trip_point_1_hyst:5000 >>> thermal_zone0/trip_point_1_temp:60000 >>> thermal_zone0/trip_point_1_type:active >>> thermal_zone0/trip_point_2_hyst:5000 >>> thermal_zone0/trip_point_2_temp:70000 >>> thermal_zone0/trip_point_2_type:active >>> thermal_zone0/trip_point_3_hyst:0 >>> thermal_zone0/trip_point_3_temp:120000 <---- this should be last one! >>> thermal_zone0/trip_point_3_type:critical >>> thermal_zone0/trip_point_4_hyst:5000 >>> thermal_zone0/trip_point_4_temp:90000 >>> thermal_zone0/trip_point_4_type:passive >>> thermal_zone0/trip_point_5_hyst:5000 >>> thermal_zone0/trip_point_5_temp:110000 >>> thermal_zone0/trip_point_5_type:passive >>> >>> After fixing the order in DT, the cpu cooler starts working. >> Ahh, nice. > Damn, not entirely. I almost fried my Odroid (it survived 130 degrees of > C)... The TMU supports only 4 trip points, so when I added two new trip > points and reordered them... the last two (including critical) was not > receiving interrupts. > > Polling mode is needed. I'll sent some patches soon... Instead of polling the driver should simply use some dynamic window for the nearest temperature ranges and reconfigure it when interrupt of occurs. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland