From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946308AbcBROuU (ORCPT ); Thu, 18 Feb 2016 09:50:20 -0500 Received: from arrakis.dune.hu ([78.24.191.176]:55618 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945930AbcBROuR (ORCPT ); Thu, 18 Feb 2016 09:50:17 -0500 Subject: Re: [PATCH V6 1/2] regulator: Add document for MT6323 regulator To: Rob Herring References: <1455709056-50510-1-git-send-email-blogic@openwrt.org> <20160218143610.GG9654@rob-hp-laptop> Cc: devicetree@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org From: John Crispin Message-ID: <56C5DA22.9080008@openwrt.org> Date: Thu, 18 Feb 2016 15:50:10 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160218143610.GG9654@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2016 15:36, Rob Herring wrote: > On Wed, Feb 17, 2016 at 12:37:35PM +0100, John Crispin wrote: >> Signed-off-by: John Crispin >> Cc: devicetree@vger.kernel.org >> >> --- >> Changes in V6 >> * remove the compatible string >> >> Changes in V5 >> * regulator vs regulators >> >> Changes in V4 >> * regulator is a subnode and not a property >> >> .../bindings/regulator/mt6323-regulator.txt | 241 ++++++++++++++++++++ >> 1 file changed, 241 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/regulator/mt6323-regulator.txt >> >> diff --git a/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt >> new file mode 100644 >> index 0000000..67c0780 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/regulator/mt6323-regulator.txt >> @@ -0,0 +1,241 @@ >> +Mediatek MT6323 Regulator Driver >> + >> +All voltage regulators are defined as subnodes of the regulators node. A list >> +of regulators provided by this controller are defined as subnodes of the >> +drivers node. Each regulator is named according to its regulator type, > > s/drivers/PMIC's/ > >> +buck_ and ldo_. The definition for each of these nodes is defined >> +using the standard binding for regulators at >> +Documentation/devicetree/bindings/regulator/regulator.txt. >> + >> +The valid names for regulators are:: >> +BUCK: >> + buck_vproc, buck_vsys, buck_vpa >> +LDO: >> + ldo_vtcxo, ldo_vcn28, ldo_vcn33_bt, ldo_vcn33_wifi, ldo_va, ldo_vcama, >> + ldo_vio28, ldo_vusb, ldo_vmc, ldo_vmch, ldo_vemc3v3, ldo_vgp1, ldo_vgp2, >> + ldo_vgp3, ldo_vcn18, ldo_vsim1, ldo_vsim2, ldo_vrtc, ldo_vcamaf, ldo_vibr, >> + ldo_vrf18, ldo_vm, ldo_vio18, ldo_vcamd, ldo_vcamio >> + >> +Example: >> + >> + pmic: mt6323 { >> + compatible = "mediatek,mt6323"; >> + >> + mt6323regulator: regulators { >> + compatible = "mediatek,mt6323-regulator"; > > Still have the compatible here... > > Otherwise: > > Acked-by: Rob Herring > grml, i only removed one of the compat strings and did not notice there are two. do you want me to send a fixup that you can fold into the one you already merged or do you want me to resend just this one patch with the fix applied ? John > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek >