From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425976AbcBRPca (ORCPT ); Thu, 18 Feb 2016 10:32:30 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:34841 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425163AbcBRPc2 (ORCPT ); Thu, 18 Feb 2016 10:32:28 -0500 Subject: Re: [PATCH] lightnvm: do not reserve lun on l2p loading To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1455707783-31789-1-git-send-email-javier@javigon.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56C5E40A.50006@lightnvm.io> Date: Thu, 18 Feb 2016 16:32:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1455707783-31789-1-git-send-email-javier@javigon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2016 12:16 PM, Javier González wrote: > When the l2p table is loaded, addresses are checked for the lun they > belong to and luns are reserved accordingly. This assumes that metadata > is being stored in the backend device to recover the previous target > configuration. Since this is not yet implemented, this check collides > with some of the core initialization (e.g., sysblock initialization when > a page is formed by several sectors). > > We take this check out and for now rely on that the right target will be > created instead. When metadata is stored to recover a target, this check > will come natural as aprt of the recovery strategy. > > FIXES c87ea75 > > Signed-off-by: Javier González > --- > drivers/lightnvm/gennvm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c > index b97801c..42c1c2a 100644 > --- a/drivers/lightnvm/gennvm.c > +++ b/drivers/lightnvm/gennvm.c > @@ -192,9 +192,6 @@ static int gennvm_block_map(u64 slba, u32 nlb, __le64 *entries, void *private) > lun_id = div_u64(pba, dev->sec_per_lun); > lun = &gn->luns[lun_id]; > > - if (!test_bit(lun_id, dev->lun_map)) > - __set_bit(lun_id, dev->lun_map); > - > /* Calculate block offset into lun */ > pba = pba - (dev->sec_per_lun * lun_id); > blk = &lun->vlun.blocks[div_u64(pba, dev->sec_per_blk)]; > Thanks Javier, applied. -Matias